Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zigbee library - change definition of addBoundDevice function (ZigbeeEP.h) #10791

Closed
1 task done
lsroka76 opened this issue Dec 30, 2024 · 4 comments
Closed
1 task done
Assignees
Labels
Area: Zigbee Issues and Feature Request about Zigbee Type: Feature request Feature request for Arduino ESP32

Comments

@lsroka76
Copy link
Contributor

Related area

Arduino Zigbee library

Hardware specification

ESP32C6/H2

Is your feature request related to a problem?

Changing definition of void addBoundDevice (protected) to virtual void addBoundDevice (public) will allow for override it in child classes.

Describe the solution you'd like

protected:
void addBoundDevice...

-->>

public:
virtual void addBoundDevice...

Describe alternatives you've considered

No response

Additional context

No response

I have checked existing list of Feature requests and the Contribution Guide

  • I confirm I have checked existing list of Feature requests and Contribution Guide.
@lsroka76 lsroka76 added the Type: Feature request Feature request for Arduino ESP32 label Dec 30, 2024
@SuGlider SuGlider added the Area: Zigbee Issues and Feature Request about Zigbee label Dec 31, 2024
@P-R-O-C-H-Y
Copy link
Member

P-R-O-C-H-Y commented Jan 6, 2025

Hi @lsroka76, why would you need to overwrite the addBoundDevice? Can you please give more informations?

@lsroka76
Copy link
Contributor Author

lsroka76 commented Jan 7, 2025

Hi @P-R-O-C-H-Y If I could overwrite addBoundDevice in my code I can i.e. match the device address with my IoT components subsystem and activate related component. In fact I've already done it in my local copy of Zigbee library ;-)

@P-R-O-C-H-Y
Copy link
Member

Hi @P-R-O-C-H-Y If I could overwrite addBoundDevice in my code I can i.e. match the device address with my IoT components subsystem and activate related component. In fact I've already done it in my local copy of Zigbee library ;-)

Feel free to also open the PR with the change :) Thanks for explaining

@P-R-O-C-H-Y
Copy link
Member

Closing this as it have been already solved by PR #10821

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Zigbee Issues and Feature Request about Zigbee Type: Feature request Feature request for Arduino ESP32
Projects
Development

No branches or pull requests

3 participants