Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IAS Zone Notification Message service to ZigbeeHandlers and ZigbeeEP.h #10821

Merged
merged 8 commits into from
Jan 27, 2025

Conversation

lsroka76
Copy link
Contributor

@lsroka76 lsroka76 commented Jan 7, 2025

Description of Change

This change will allow to handle SP_ZB_CORE_CMD_IAS_ZONE_ZONE_STATUS_CHANGE_NOT_ID in zb_action_handler and dispatch it to destination endpoint for further processing.

Tests scenarios

Tested on ESP32 C6 with Tuya open window sensors (TS0203).

Related links

eg. Closes #10794 of issue

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Update ZigbeeEP.h":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update ZigbeeEP.h":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update ZigbeeHandlers.cpp":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello lsroka76, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 9d7e887

@CLAassistant
Copy link

CLAassistant commented Jan 7, 2025

CLA assistant check
All committers have signed the CLA.

make addBoundDevice virtual for override
@me-no-dev
Copy link
Member

in order to process this PR, you need to sign the CLA and add a short description of what it's about. What is IAS Zone Notification and why it matters.

@P-R-O-C-H-Y P-R-O-C-H-Y self-requested a review January 7, 2025 11:12
@P-R-O-C-H-Y P-R-O-C-H-Y added the Area: Zigbee Issues and Feature Request about Zigbee label Jan 7, 2025
@P-R-O-C-H-Y P-R-O-C-H-Y linked an issue Jan 7, 2025 that may be closed by this pull request
1 task
@lucasssvaz lucasssvaz added the Status: Review needed Issue or PR is awaiting review label Jan 8, 2025
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32C6💚 -66⚠️ +134💚 -0.01⚠️ +0.02000.000.00
ESP32H2💚 -66⚠️ +134💚 -0.01⚠️ +0.02000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32C6ESP32H2
ExampleFLASHRAMFLASHRAM
Zigbee/examples/Zigbee_CarbonDioxide_Sensor⚠️ +640⚠️ +640
Zigbee/examples/Zigbee_Color_Dimmable_Light⚠️ +640⚠️ +640
Zigbee/examples/Zigbee_Color_Dimmer_Switch⚠️ +1340⚠️ +1340
Zigbee/examples/Zigbee_Dimmable_Light⚠️ +640⚠️ +640
Zigbee/examples/Zigbee_Occupancy_Sensor⚠️ +640⚠️ +640
Zigbee/examples/Zigbee_On_Off_Light⚠️ +640⚠️ +640
Zigbee/examples/Zigbee_On_Off_Switch⚠️ +1300⚠️ +1300
Zigbee/examples/Zigbee_Pressure_Flow_Sensor⚠️ +720⚠️ +720
Zigbee/examples/Zigbee_Scan_Networks💚 -660💚 -660
Zigbee/examples/Zigbee_Temp_Hum_Sensor_Sleepy⚠️ +620⚠️ +640
Zigbee/examples/Zigbee_Temperature_Sensor⚠️ +620⚠️ +640
Zigbee/examples/Zigbee_Thermostat⚠️ +1300⚠️ +1300

Copy link
Contributor

github-actions bot commented Jan 8, 2025

Test Results

 62 files   62 suites   5m 39s ⏱️
 21 tests  21 ✅ 0 💤 0 ❌
154 runs  154 ✅ 0 💤 0 ❌

Results for commit 9d7e887.

♻️ This comment has been updated with latest results.

@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Jan 27, 2025
@me-no-dev me-no-dev merged commit 15cbb1e into espressif:master Jan 27, 2025
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Zigbee Issues and Feature Request about Zigbee Status: Pending Merge Pull Request is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zigbee library - ZigbeeHandlers enhancement (IAS Zone Notification message)
5 participants