-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ppp): Fix PPP not working after reboot if no RST #10264
Conversation
Modem will try to switch to CMUX and then back to COMMAND in order to allow communication with the modem.
👋 Hello me-no-dev, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
Test Results 56 files - 83 56 suites - 83 4m 53s ⏱️ - 1h 37m 52s Results for commit b93d0e9. ± Comparison against base commit 396def3. This pull request removes 9 tests.
♻️ This comment has been updated with latest results. |
I can confirm that the fix works for SIM7600E modem, so it resolves my issue. |
Modem will try to switch to CMUX and then back to COMMAND in order to allow communication with the modem.
This does not work on SIM800, so RST pin should always be connected to ensure proper reset is possible on boot.
Fixes: #10237