Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api): Update Arduino Stream class #10328

Merged
merged 3 commits into from
Sep 13, 2024
Merged

fix(api): Update Arduino Stream class #10328

merged 3 commits into from
Sep 13, 2024

Conversation

me-no-dev
Copy link
Member

Upstream code contains some fixes

@me-no-dev
fix(api): Update Arduino Stream class
b5876f1 
Upstream code contains some fixes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 11, 2024 •
edited
Loading

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Update Stream.h":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).
⚠️ The Pull Request description looks very brief, please check if more details can be added.
Messages
📖 You might consider squashing your 3 commits (simplifying branch history).

👋 Hello me-no-dev, we appreciate your contribution to this project!

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against c53e63c

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 11, 2024 •
edited
Loading

Test Results

 56 files   -  83   56 suites   - 83   4m 21s ⏱️ - 1h 37m 53s
 21 tests  -   9   21 ✅  -   9  0 💤 ±0  0 ❌ ±0 
135 runs   - 168  135 ✅  - 168  0 💤 ±0  0 ❌ ±0 

Results for commit c53e63c. ± Comparison against base commit 1e04762.

This pull request removes 9 tests. 
performance.coremark.test_coremark ‑ test_coremark
performance.fibonacci.test_fibonacci ‑ test_fibonacci
performance.psramspeed.test_psramspeed ‑ test_psramspeed
performance.ramspeed.test_ramspeed ‑ test_ramspeed
performance.superpi.test_superpi ‑ test_superpi
test_touch_errors
test_touch_interrtupt
test_touch_read
validation.periman.test_periman ‑ test_periman

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 11, 2024 •
edited
Loading

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32S3💚 -3K0💚 -1.120.00💚 -160💚 -0.090.00
ESP32S2💚 -3K0💚 -1.240.00💚 -160💚 -0.120.00
ESP32C3💚 -11440💚 -0.430.00💚 -160💚 -0.140.00
ESP32C6💚 -11420💚 -0.530.00💚 -160💚 -0.130.00
ESP32H2💚 -11480💚 -0.440.00💚 -160💚 -0.130.00
ESP32💚 -3K0💚 -1.100.00💚 -160💚 -0.080.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32S3ESP32S2ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
ArduinoOTA/examples/BasicOTA💚 -5400💚 -5640💚 -3380💚 -3300--💚 -5320
AsyncUDP/examples/AsyncUDPClient💚 -6280💚 -6200💚 -4560💚 -4560--💚 -6280
AsyncUDP/examples/AsyncUDPMulticastServer💚 -6440💚 -6200💚 -4560💚 -4560--💚 -5960
AsyncUDP/examples/AsyncUDPServer💚 -6440💚 -6280💚 -4560💚 -4560--💚 -6600
BLE/examples/BLE5_extended_scan💚 -7800--💚 -2460💚 -2380💚 -2460--
BLE/examples/BLE5_multi_advertising💚 -7520--💚 -2460💚 -2540💚 -2460--
BLE/examples/BLE5_periodic_advertising💚 -7480--💚 -2460💚 -2540💚 -2460--
BLE/examples/BLE5_periodic_sync💚 -7360--💚 -2540💚 -2460💚 -2540--
BLE/examples/Beacon_Scanner💚 -7760--💚 -2460💚 -2540💚 -2540💚 -8080
BLE/examples/Client💚 -7520--💚 -2380💚 -2460💚 -2460💚 -7920
BLE/examples/EddystoneTLM_Beacon💚 -7560--💚 -2460💚 -2380--💚 -7920
BLE/examples/EddystoneURL_Beacon💚 -7840--💚 -2460💚 -2540--💚 -7920
BLE/examples/Notify💚 -7680--💚 -2460💚 -2540💚 -2460💚 -7720
BLE/examples/Scan💚 -7440--💚 -2540💚 -2460💚 -2460💚 -7880
BLE/examples/Server💚 -7800--💚 -2460💚 -2540💚 -2460💚 -7840
BLE/examples/Server_multiconnect💚 -7720--💚 -2380💚 -2460💚 -2380💚 -7960
BLE/examples/UART💚 -7640--💚 -2460💚 -2540💚 -2460💚 -7960
BLE/examples/Write💚 -7680--💚 -2440💚 -2520💚 -2440💚 -7960
BLE/examples/iBeacon💚 -7600--💚 -2460💚 -2540💚 -2460💚 -7920
DNSServer/examples/CaptivePortal💚 -5480💚 -5800💚 -2900💚 -2980--💚 -5720
EEPROM/examples/eeprom_class💚 -4480💚 -4480💚 -3700💚 -3740💚 -3740💚 -4600
EEPROM/examples/eeprom_extra💚 -4360💚 -4360💚 -3760💚 -3700💚 -3720💚 -4480
EEPROM/examples/eeprom_write💚 -8680💚 -8680💚 -3720💚 -3720💚 -3720💚 -8800
ESP32/examples/AnalogOut/LEDCFade💚 -2K💚 -16💚 -2K💚 -16💚 -1036💚 -16💚 -1038💚 -16💚 -1038💚 -16💚 -2K💚 -16
ESP32/examples/AnalogOut/LEDCSingleChannel💚 -3K💚 -16💚 -3K💚 -16💚 -1042💚 -16💚 -1042💚 -16💚 -1050💚 -16💚 -3K💚 -16
ESP32/examples/AnalogOut/LEDCSoftwareFade💚 -3K💚 -16💚 -3K💚 -16💚 -1042💚 -16💚 -1042💚 -16💚 -1050💚 -16💚 -3K💚 -16
ESP32/examples/AnalogOut/SigmaDelta💚 -3K💚 -16💚 -3K💚 -16💚 -1030💚 -16💚 -1032💚 -16💚 -1040💚 -16💚 -3K💚 -16
ESP32/examples/AnalogOut/ledcFrequency💚 -3K💚 -16💚 -3K💚 -16💚 -1054💚 -16💚 -1038💚 -16💚 -1038💚 -16💚 -3K💚 -16
ESP32/examples/AnalogOut/ledcWrite_RGB💚 -2K💚 -16💚 -2K💚 -16💚 -1040💚 -16💚 -1044💚 -16💚 -1044💚 -16💚 -2K💚 -16
ESP32/examples/AnalogRead💚 -2K💚 -16💚 -2K💚 -16💚 -1050💚 -16💚 -1042💚 -16💚 -1050💚 -16💚 -2K💚 -16
ESP32/examples/AnalogReadContinuous💚 -2K💚 -16💚 -2K💚 -16💚 -1034💚 -16💚 -1028💚 -16💚 -1036💚 -16💚 -2K💚 -16
ESP32/examples/ArduinoStackSize💚 -2K💚 -16💚 -2K💚 -16💚 -1024💚 -16💚 -1026💚 -16💚 -1026💚 -16💚 -2K💚 -16
ESP32/examples/CI/CIBoardsTest💚 -2K💚 -16💚 -2K💚 -16💚 -1124💚 -16💚 -1118💚 -16💚 -1126💚 -16💚 -2K💚 -16
ESP32/examples/Camera/CameraWebServer💚 -5120💚 -5360------💚 -5240
ESP32/examples/ChipID/GetChipID💚 -4480💚 -4400💚 -3780💚 -3760💚 -3740💚 -4600
ESP32/examples/DeepSleep/ExternalWakeUp💚 -7640💚 -7560------💚 -7840
ESP32/examples/DeepSleep/TimerWakeUp💚 -7640💚 -7560💚 -2400💚 -2420--💚 -7840
ESP32/examples/DeepSleep/TouchWakeUp💚 -7640💚 -7640------💚 -7680
ESP32/examples/FreeRTOS/BasicMultiThreading💚 -2K💚 -16💚 -2K💚 -16💚 -1042💚 -16💚 -1036💚 -16💚 -1046💚 -16💚 -2K💚 -16
ESP32/examples/FreeRTOS/Mutex💚 -2K💚 -16💚 -2K💚 -16💚 -1042💚 -16💚 -1042💚 -16💚 -1044💚 -16💚 -2K💚 -16
ESP32/examples/FreeRTOS/Queue💚 -2K💚 -16💚 -2K💚 -16💚 -1030💚 -16💚 -1032💚 -16💚 -1036💚 -16💚 -2K💚 -16
ESP32/examples/FreeRTOS/Semaphore💚 -2K💚 -16💚 -2K💚 -16💚 -1028💚 -16💚 -1030💚 -16💚 -1030💚 -16💚 -2K💚 -16
ESP32/examples/GPIO/BlinkRGB💚 -3K💚 -16💚 -3K💚 -16💚 -1040💚 -16💚 -1030💚 -16💚 -1040💚 -16💚 -3K💚 -16
ESP32/examples/GPIO/FunctionalInterrupt💚 -2K💚 -16💚 -2K💚 -16💚 -1042💚 -16💚 -1032💚 -16💚 -1040💚 -16💚 -2K💚 -16
ESP32/examples/GPIO/FunctionalInterruptStruct💚 -2K💚 -16💚 -2K💚 -16💚 -1042💚 -16💚 -1044💚 -16💚 -1042💚 -16💚 -2K💚 -16
ESP32/examples/GPIO/GPIOInterrupt💚 -2K💚 -16💚 -2K💚 -16💚 -1036💚 -16💚 -1040💚 -16💚 -1034💚 -16💚 -2K💚 -16
ESP32/examples/HWCDC_Events💚 -2K💚 -16--💚 -1118💚 -16💚 -1114💚 -16💚 -1116💚 -16--
ESP32/examples/MacAddress/GetMacAddress💚 -8560💚 -8480💚 -3800💚 -3800💚 -3780💚 -8680
ESP32/examples/RMT/Legacy_RMT_Driver_Compatible💚 -7640💚 -7560💚 -2420💚 -2400💚 -2400💚 -7840
ESP32/examples/RMT/RMTCallback💚 -2K💚 -16💚 -2K💚 -16💚 -1036💚 -16💚 -1028💚 -16💚 -1038💚 -16💚 -2K💚 -16
ESP32/examples/RMT/RMTLoopback💚 -2K💚 -16💚 -2K💚 -16💚 -1028💚 -16💚 -1028💚 -16💚 -1028💚 -16💚 -2K💚 -16
ESP32/examples/RMT/RMTReadXJT💚 -2K💚 -16💚 -2K💚 -16💚 -1038💚 -16💚 -1038💚 -16💚 -1042💚 -16💚 -2K💚 -16
ESP32/examples/RMT/RMTWrite_RGB_LED💚 -2K💚 -16💚 -2K💚 -16💚 -1022💚 -16💚 -1022💚 -16💚 -1022💚 -16💚 -2K💚 -16
ESP32/examples/RMT/RMT_CPUFreq_Test💚 -2K💚 -16💚 -2K💚 -16💚 -1032💚 -16💚 -1034💚 -16💚 -1032💚 -16💚 -2K💚 -16
ESP32/examples/RMT/RMT_EndOfTransmissionState💚 -2K💚 -16💚 -2K💚 -16💚 -1040💚 -16💚 -1040💚 -16💚 -1042💚 -16💚 -2K💚 -16
ESP32/examples/RMT/RMT_LED_Blink💚 -2K💚 -16💚 -2K💚 -16💚 -1032💚 -16💚 -1036💚 -16💚 -1036💚 -16💚 -2K💚 -16
ESP32/examples/ResetReason/ResetReason💚 -2K💚 -16💚 -2K💚 -16💚 -1030💚 -16💚 -1032💚 -16💚 -1034💚 -16💚 -2K💚 -16
ESP32/examples/ResetReason/ResetReason2💚 -2K💚 -16💚 -2K💚 -16💚 -1036💚 -16💚 -1036💚 -16💚 -1036💚 -16💚 -2K💚 -16
ESP32/examples/Serial/BaudRateDetect_Demo💚 -2K💚 -16💚 -2K💚 -16💚 -1040💚 -16💚 -1042💚 -16💚 -1042💚 -16💚 -2K💚 -16
ESP32/examples/Serial/OnReceiveError_BREAK_Demo💚 -2K💚 -16💚 -2K💚 -16💚 -1036💚 -16💚 -1036💚 -16💚 -1042💚 -16💚 -2K💚 -16
ESP32/examples/Serial/OnReceive_Demo💚 -2K💚 -16💚 -2K💚 -16💚 -1038💚 -16💚 -1040💚 -16💚 -1038💚 -16💚 -2K💚 -16
ESP32/examples/Serial/RS485_Echo_Demo💚 -2K💚 -16💚 -2K💚 -16💚 -1038💚 -16💚 -1038💚 -16💚 -1038💚 -16💚 -2K💚 -16
ESP32/examples/Serial/RxFIFOFull_Demo💚 -2K💚 -16💚 -2K💚 -16💚 -1040💚 -16💚 -1040💚 -16💚 -1038💚 -16💚 -2K💚 -16
ESP32/examples/Serial/RxTimeout_Demo💚 -2K💚 -16💚 -2K💚 -16💚 -1034💚 -16💚 -1032💚 -16💚 -1032💚 -16💚 -2K💚 -16
ESP32/examples/Serial/Serial_All_CPU_Freqs💚 -2K💚 -16💚 -2K💚 -16💚 -1042💚 -16💚 -1042💚 -16💚 -1042💚 -16💚 -2K💚 -16
ESP32/examples/Serial/Serial_STD_Func_OnReceive💚 -2K💚 -16💚 -2K💚 -16💚 -1030💚 -16💚 -1030💚 -16💚 -1028💚 -16💚 -2K💚 -16
ESP32/examples/Serial/onReceiveExample💚 -7400💚 -7400💚 -2180💚 -2180💚 -2180💚 -7480
ESP32/examples/TWAI/TWAIreceive💚 -2K💚 -16💚 -2K💚 -16💚 -1042💚 -16💚 -1040💚 -16💚 -1042💚 -16💚 -2K💚 -16
ESP32/examples/TWAI/TWAItransmit💚 -2K💚 -16💚 -2K💚 -16💚 -1050💚 -16💚 -1048💚 -16💚 -1048💚 -16💚 -2K💚 -16
ESP32/examples/Template/ExampleTemplate💚 -3K💚 -16💚 -3K💚 -16💚 -1054💚 -16💚 -1050💚 -16💚 -1060💚 -16💚 -3K💚 -16
ESP32/examples/Time/SimpleTime💚 -5240💚 -5400💚 -3640💚 -3640--💚 -5440
ESP32/examples/Timer/RepeatTimer💚 -2K💚 -16💚 -2K💚 -16💚 -1038💚 -16💚 -1042💚 -16💚 -1044💚 -16💚 -2K💚 -16
ESP32/examples/Timer/WatchdogTimer💚 -2K💚 -16💚 -2K💚 -16💚 -1040💚 -16💚 -1044💚 -16💚 -1042💚 -16💚 -2K💚 -16
ESP32/examples/Touch/TouchButtonV2💚 -2K💚 -16💚 -2K💚 -16--------
ESP32/examples/Touch/TouchInterrupt💚 -2K💚 -16💚 -2K💚 -16------💚 -2K💚 -16
ESP32/examples/Touch/TouchRead💚 -2K💚 -16💚 -2K💚 -16------💚 -2K💚 -16
ESP32/examples/Utilities/HEXBuilder💚 -8560💚 -8560💚 -3640💚 -3640💚 -3600💚 -8680
ESP32/examples/Utilities/MD5Builder💚 -3560💚 -3520💚 -2580💚 -2580💚 -2580💚 -3440
ESP32/examples/Utilities/SHA1Builder💚 -3560💚 -3600💚 -2520💚 -2520💚 -2520💚 -3440
ESP_I2S/examples/ES8388_loopback💚 -2K💚 -16💚 -2K💚 -16💚 -1144💚 -16💚 -1142💚 -16💚 -1148💚 -16💚 -2K💚 -16
ESP_I2S/examples/Record_to_WAV💚 -9280--------💚 -9560
ESP_I2S/examples/Simple_tone💚 -2K💚 -16💚 -2K💚 -16💚 -1052💚 -16💚 -1064💚 -16💚 -1064💚 -16💚 -2K💚 -16
ESP_NOW/examples/ESP_NOW_Broadcast_Master💚 -4600💚 -4480💚 -2360💚 -2480--💚 -4600
ESP_NOW/examples/ESP_NOW_Broadcast_Slave💚 -4680💚 -4560💚 -2400💚 -2480--💚 -4800
ESP_NOW/examples/ESP_NOW_Network💚 -4560💚 -4600💚 -2440💚 -2520--💚 -4640
ESP_NOW/examples/ESP_NOW_Serial💚 -6600💚 -6320💚 -4600💚 -4680--💚 -6400
ESP_SR/examples/Basic💚 -5040----------
ESPmDNS/examples/mDNS-SD_Extended💚 -5080💚 -5360💚 -3720💚 -3820--💚 -5440
ESPmDNS/examples/mDNS_Web_Server💚 -4920💚 -4840💚 -3200💚 -3220--💚 -5040
Ethernet/examples/ETH_W5500_Arduino_SPI💚 -6280💚 -6480💚 -5120💚 -5120💚 -5120💚 -6560
Ethernet/examples/ETH_W5500_IDF_SPI💚 -6320💚 -6280💚 -5120💚 -5120💚 -5120💚 -6560
Ethernet/examples/ETH_WIFI_BRIDGE💚 -5440💚 -5120💚 -3720💚 -3640--💚 -5240
FFat/examples/FFat_Test💚 -8480💚 -8560💚 -2780💚 -2780💚 -2700💚 -8680
FFat/examples/FFat_time💚 -5680💚 -5760💚 -3200💚 -3200--💚 -5960
HTTPClient/examples/Authorization💚 -5280💚 -5200💚 -3060💚 -3060--💚 -5360
HTTPClient/examples/BasicHttpClient💚 -5280💚 -5280💚 -3140💚 -3140--💚 -5360
HTTPClient/examples/BasicHttpsClient💚 -5120💚 -5360💚 -3060💚 -3060--💚 -5400
HTTPClient/examples/HTTPClientEnterprise💚 -5560💚 -5800💚 -3260💚 -3240--💚 -5880
HTTPClient/examples/ReuseConnection💚 -5200💚 -5280💚 -3040💚 -3040--💚 -5400
HTTPClient/examples/StreamHttpClient💚 -5040💚 -5320💚 -3160💚 -3140--💚 -5400
HTTPUpdate/examples/httpUpdate💚 -5560💚 -5840💚 -3540💚 -3540--💚 -5680
HTTPUpdate/examples/httpUpdateSPIFFS💚 -5480💚 -5640💚 -3540💚 -3540--💚 -5520
HTTPUpdate/examples/httpUpdateSecure💚 -5520💚 -5800💚 -3720💚 -3800--💚 -6040
HTTPUpdateServer/examples/WebUpdater💚 -5720💚 -5800💚 -3060💚 -3140--💚 -5640
Insights/examples/DiagnosticsSmokeTest💚 -5320💚 -5320💚 -3640----💚 -5560
Insights/examples/MinimalDiagnostics💚 -5440💚 -5440💚 -3740----💚 -5440
LittleFS/examples/LITTLEFS_test💚 -8640💚 -8560💚 -2800💚 -2820💚 -2720💚 -8840
LittleFS/examples/LITTLEFS_time💚 -5480💚 -5720💚 -3200💚 -3200--💚 -5600
NetBIOS/examples/ESP_NBNST💚 -6440💚 -6200💚 -4600💚 -4520--💚 -6120
NetworkClientSecure/examples/WiFiClientInsecure💚 -6080💚 -6240💚 -4340💚 -4260--💚 -6240
NetworkClientSecure/examples/WiFiClientPSK💚 -5920💚 -6160💚 -4340💚 -4260--💚 -6240
NetworkClientSecure/examples/WiFiClientSecure💚 -5800💚 -6120💚 -4260💚 -4180--💚 -6080
NetworkClientSecure/examples/WiFiClientSecureEnterprise💚 -6480💚 -6840💚 -4360💚 -4460--💚 -6520
NetworkClientSecure/examples/WiFiClientSecureProtocolUpgrade💚 -6160💚 -6280💚 -4280💚 -4360--💚 -6240
NetworkClientSecure/examples/WiFiClientShowPeerCredentials💚 -5880💚 -6080💚 -4300💚 -4300--💚 -6080
NetworkClientSecure/examples/WiFiClientTrustOnFirstUse💚 -6000💚 -6120💚 -4260💚 -4340--💚 -6280
PPP/examples/PPP_Basic💚 -6280💚 -6400💚 -5260💚 -5260💚 -5200💚 -6520
PPP/examples/PPP_WIFI_BRIDGE💚 -5400💚 -5160💚 -3720💚 -3720--💚 -5360
Preferences/examples/Prefs2Struct💚 -8680💚 -8600💚 -3740💚 -3740💚 -3720💚 -8800
Preferences/examples/StartCounter💚 -4480💚 -4600💚 -3820💚 -3820💚 -3800💚 -4600
RainMaker/examples/RMakerCustom💚 -5480💚 -5360💚 -3720💚 -3720--💚 -6320
RainMaker/examples/RMakerCustomAirCooler💚 -5320💚 -5400💚 -3800💚 -3800--💚 -5440
RainMaker/examples/RMakerSonoffDualR3💚 -5320💚 -5400💚 -3800💚 -3800--💚 -5520
RainMaker/examples/RMakerSwitch💚 -5480💚 -5240💚 -3780💚 -3780--💚 -6200
SD/examples/SD_Test💚 -8480💚 -8560💚 -2740💚 -2760💚 -2680💚 -8840
SD/examples/SD_time💚 -5640💚 -5480💚 -3160💚 -3160--💚 -6040
SD_MMC/examples/SD2USBMSC💚 -9120----------
SD_MMC/examples/SDMMC_Test💚 -8480--------💚 -8840
SD_MMC/examples/SDMMC_time💚 -5720--------💚 -5800
SPI/examples/SPI_Multiple_Buses💚 -3K💚 -16💚 -3K💚 -16------💚 -3K💚 -16
SPIFFS/examples/SPIFFS_Test💚 -8480💚 -8600💚 -2700💚 -2680💚 -2680💚 -8840
SPIFFS/examples/SPIFFS_time💚 -5480💚 -5760💚 -3180💚 -3180--💚 -5800
SimpleBLE/examples/SimpleBleDevice💚 -3360----💚 -2360💚 -2360💚 -3760
TFLiteMicro/examples/hello_world💚 -3K💚 -16💚 -3K💚 -16💚 -1038💚 -16💚 -1036💚 -16💚 -1042💚 -16💚 -3K💚 -16
Ticker/examples/Blinker💚 -3K💚 -16💚 -3K💚 -16💚 -1050💚 -16💚 -1032💚 -16💚 -1038💚 -16💚 -3K💚 -16
Ticker/examples/TickerBasic💚 -3K💚 -16💚 -3K💚 -16💚 -1048💚 -16💚 -1032💚 -16💚 -1038💚 -16💚 -3K💚 -16
Ticker/examples/TickerParameter💚 -3K💚 -16💚 -3K💚 -16💚 -1040💚 -16💚 -1024💚 -16💚 -1032💚 -16💚 -3K💚 -16
USB/examples/CompositeDevice💚 -9560💚 -9600--------
USB/examples/ConsumerControl💚 -9360💚 -9040--------
USB/examples/CustomHIDDevice💚 -8960💚 -8960--------
USB/examples/FirmwareMSC💚 -8640💚 -8480--------
USB/examples/Gamepad💚 -8960💚 -8960--------
USB/examples/HIDVendor💚 -9120💚 -9040--------
USB/examples/Keyboard/KeyboardLogout💚 -9200💚 -9080--------
USB/examples/Keyboard/KeyboardMessage💚 -9200💚 -9080--------
USB/examples/Keyboard/KeyboardReprogram💚 -9200💚 -8960--------
USB/examples/Keyboard/KeyboardSerial💚 -8960💚 -8960--------
USB/examples/KeyboardAndMouseControl💚 -8960💚 -8960--------
USB/examples/MIDI/MidiController💚 -8960💚 -8960--------
USB/examples/MIDI/MidiInterface💚 -8960💚 -8960--------
USB/examples/MIDI/MidiMusicBox💚 -8960💚 -8960--------
USB/examples/MIDI/ReceiveMidi💚 -8960💚 -8960--------
USB/examples/Mouse/ButtonMouseControl💚 -9360💚 -8960--------
USB/examples/SystemControl💚 -9200💚 -9040--------
USB/examples/USBMSC💚 -8480💚 -8560--------
USB/examples/USBSerial💚 -8920💚 -8960--------
USB/examples/USBVendor💚 -9160💚 -9160--------
Update/examples/AWS_S3_OTA_Update💚 -4320💚 -4480💚 -2540💚 -2620--💚 -4560
Update/examples/HTTPS_OTA_Update💚 -4280💚 -4520💚 -2720💚 -2720--💚 -4600
Update/examples/HTTP_Client_AES_OTA_Update💚 -5640💚 -5720💚 -3580💚 -3520--💚 -5840
Update/examples/HTTP_Server_AES_OTA_Update💚 -6120💚 -6280💚 -3340💚 -3280--💚 -6240
Update/examples/OTAWebUpdater💚 -5000💚 -5000💚 -2520💚 -2440--💚 -5280
Update/examples/SD_Update💚 -4000💚 -3960💚 -2020💚 -2100💚 -2100💚 -4120
WebServer/examples/AdvancedWebServer💚 -4760💚 -4640💚 -2200💚 -2120--💚 -4760
WebServer/examples/FSBrowser💚 -5000💚 -5320💚 -2340💚 -2260--💚 -5120
WebServer/examples/Filters💚 -4760💚 -4640💚 -2120💚 -2200--💚 -4760
WebServer/examples/HelloServer💚 -4720💚 -4680💚 -2120💚 -2200--💚 -4800
WebServer/examples/HttpAdvancedAuth💚 -5040💚 -5200💚 -2280💚 -2380--💚 -5160
WebServer/examples/HttpAuthCallback💚 -4880💚 -5120💚 -2480💚 -2400--💚 -5040
WebServer/examples/HttpAuthCallbackInline💚 -4880💚 -5280💚 -2460💚 -2380--💚 -5120
WebServer/examples/HttpBasicAuth💚 -5040💚 -5160💚 -2440💚 -2360--💚 -5120
WebServer/examples/HttpBasicAuthSHA1💚 -5000💚 -5120💚 -2400💚 -2320--💚 -5040
WebServer/examples/HttpBasicAuthSHA1orBearerToken💚 -4720💚 -5080💚 -2440💚 -2340--💚 -5160
WebServer/examples/MultiHomedServers💚 -4720💚 -4640💚 -2120💚 -2200--💚 -4640
WebServer/examples/PathArgServer💚 -4800💚 -4920💚 -2120💚 -2120--💚 -4680
WebServer/examples/SDWebServer💚 -4920💚 -5280💚 -2320💚 -2400--💚 -5160
WebServer/examples/SimpleAuthentification💚 -4640💚 -4640💚 -2200💚 -2120--💚 -4720
WebServer/examples/UploadHugeFile💚 -5360💚 -5720💚 -3000💚 -2840--💚 -5680
WebServer/examples/WebServer💚 -6400💚 -6640💚 -4080💚 -4080--💚 -6600
WebServer/examples/WebUpdate💚 -4320💚 -4280💚 -1520💚 -1500--💚 -4280
WiFi/examples/FTM/FTM_Initiator💚 -5320💚 -4920💚 -3720💚 -3800--💚 -5520
WiFi/examples/FTM/FTM_Responder💚 -5120💚 -5280💚 -3680💚 -3800--💚 -5480
WiFi/examples/SimpleWiFiServer💚 -5120💚 -5240💚 -3620💚 -3700--💚 -5400
WiFi/examples/WPS💚 -4200💚 -4240💚 -2440💚 -2360--💚 -4640
WiFi/examples/WiFiAccessPoint💚 -5160💚 -5360💚 -3620💚 -3700--💚 -5600
WiFi/examples/WiFiBlueToothSwitch💚 -5120--💚 -3840💚 -3760--💚 -5480
WiFi/examples/WiFiClient💚 -4800💚 -4800💚 -3160💚 -3140--💚 -5120
WiFi/examples/WiFiClientBasic💚 -4800💚 -4800💚 -3140💚 -3140--💚 -5360
WiFi/examples/WiFiClientConnect💚 -5200💚 -5400💚 -3640💚 -3720--💚 -5320
WiFi/examples/WiFiClientEnterprise💚 -4800💚 -4760💚 -3140💚 -3120--💚 -4840
WiFi/examples/WiFiClientEvents💚 -5120💚 -5360💚 -3640💚 -3760--💚 -5320
WiFi/examples/WiFiClientStaticIP💚 -4800💚 -4760💚 -3140💚 -3140--💚 -5160
WiFi/examples/WiFiExtender💚 -5440💚 -5480💚 -3800💚 -3760--💚 -5440
WiFi/examples/WiFiIPv6💚 -5880💚 -6080💚 -4660💚 -4580--💚 -6080
WiFi/examples/WiFiMulti💚 -5520💚 -5160💚 -3720💚 -3660--💚 -5240
WiFi/examples/WiFiMultiAdvanced💚 -5880💚 -6120💚 -4260💚 -4260--💚 -6440
WiFi/examples/WiFiScan💚 -5320💚 -5120💚 -3720💚 -3640--💚 -5560
WiFi/examples/WiFiScanAsync💚 -5240💚 -5080💚 -3760💚 -3680--💚 -5600
WiFi/examples/WiFiScanDualAntenna💚 -5360💚 -5160💚 -3720💚 -3840--💚 -5440
WiFi/examples/WiFiScanTime💚 -5040💚 -5080💚 -3860💚 -3760--💚 -5440
WiFi/examples/WiFiSmartConfig💚 -5160💚 -5240💚 -3680💚 -3720--💚 -5360
WiFi/examples/WiFiTelnetToSerial💚 -6440💚 -6160💚 -5120💚 -5200--💚 -6520
WiFi/examples/WiFiUDPClient💚 -4920💚 -5000💚 -3380💚 -3320--💚 -5320
WiFiProv/examples/WiFiProv💚 -4800💚 -5320💚 -3740💚 -3720--💚 -5480
Wire/examples/WireMaster💚 -4600💚 -4720💚 -3420💚 -3360💚 -3360💚 -4720
Wire/examples/WireScan💚 -2K💚 -16💚 -2K💚 -16💚 -1118💚 -16💚 -1114💚 -16💚 -1112💚 -16💚 -2K💚 -16
Wire/examples/WireSlave💚 -2K💚 -16💚 -2K💚 -16💚 -1124💚 -16💚 -1112💚 -16💚 -1110💚 -16💚 -2K💚 -16
OpenThread/examples/COAP/coap_lamp------💚 -2560💚 -2580--
OpenThread/examples/COAP/coap_switch------💚 -2500💚 -2480--
OpenThread/examples/SimpleCLI------💚 -2940💚 -3020--
OpenThread/examples/SimpleNode------💚 -2800💚 -2840--
OpenThread/examples/SimpleThreadNetwork/ExtendedRouterNode------💚 -2800💚 -2820--
OpenThread/examples/SimpleThreadNetwork/LeaderNode------💚 -2960💚 -3040--
OpenThread/examples/SimpleThreadNetwork/RouterNode------💚 -2960💚 -3040--
OpenThread/examples/ThreadScan------💚 -2520💚 -2600--
OpenThread/examples/onReceive------💚 -3020💚 -3020--
BluetoothSerial/examples/DiscoverConnect----------💚 -5560
BluetoothSerial/examples/GetLocalMAC----------💚 -5320
BluetoothSerial/examples/SerialToSerialBT----------💚 -5680
BluetoothSerial/examples/SerialToSerialBTM----------💚 -5640
BluetoothSerial/examples/SerialToSerialBT_Legacy----------💚 -5000
BluetoothSerial/examples/SerialToSerialBT_SSP----------💚 -5200
BluetoothSerial/examples/bt_classic_device_discovery----------💚 -5800
BluetoothSerial/examples/bt_remove_paired_devices----------💚 -5480
ESP32/examples/DeepSleep/SmoothBlink_ULP_Code----------💚 -2K💚 -16
ESP32/examples/Touch/TouchButton----------💚 -2K💚 -16
Ethernet/examples/ETH_LAN8720----------💚 -6720
Ethernet/examples/ETH_TLK110----------💚 -6720

@me-no-dev me-no-dev added Status: Pending Merge Pull Request is ready to be merged labels Sep 11, 2024
@me-no-dev me-no-dev mentioned this pull request Sep 11, 2024
Closed
@VojtechBartoska VojtechBartoska added this to the 3.0.5 milestone Sep 11, 2024
@me-no-dev me-no-dev merged commit 648094c into master Sep 13, 2024
57 checks passed
@me-no-dev me-no-dev deleted the feature/update_stream branch September 13, 2024 07:49
TD-er added a commit to TD-er/arduino-esp32 that referenced this pull request Sep 14, 2024
@TD-er
Fix missing virtual declarations in Stream.h
00e9c78 
Fixes some changes made in PR espressif#10328
@TD-er TD-er mentioned this pull request Sep 14, 2024
Merged
me-no-dev pushed a commit that referenced this pull request Sep 17, 2024
@TD-er
Fix missing virtual declarations in Stream.h (#10348)
e989445 
* Fix missing virtual declarations in Stream.h

Fixes some changes made in PR #10328

* Remove the virtual destructor as Print class has one

As pointed out by @JAndrassy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-R-O-C-H-Y P-R-O-C-H-Y Awaiting requested review from P-R-O-C-H-Y

Assignees
No one assigned
Labels
Status: Pending Merge Pull Request is ready to be merged
Projects
None yet
Milestone
3.0.5
Development

Successfully merging this pull request may close these issues.
2 participants
@me-no-dev @VojtechBartoska