Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DNSServer Lib - improper startup code in WiFi mode #10366

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

vortigont
Copy link
Contributor

When running on WiFi-AP mode server's start() method returned true while in fact UDP listening socket was never created
Regression introduced in #8760
Closes #10330

When running on WiFi-AP mode server's start() method returned true while in fact UDP listening socket was never created
Regression introduced in espressif#8760
Closes espressif#10330
Copy link
Contributor

github-actions bot commented Sep 22, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "DNSServer: fix improper startup code in WiFi mode":
    • body's lines must not be longer than 100 characters
    • footer must have leading blank line
    • type/action should start with a lowercase letter
    • type/action should be one of [change, ci, docs, feat, fix, refactor, remove, revert, test]

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

⚠️

The source branch "DNSSRV_fix" incorrect format:

  • contains uppercase letters. This can cause troubles on case-insensitive file systems (macOS).
    Please rename your branch.

👋 Hello vortigont, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against a7c21df

Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32S30⚠️ +880.00⚠️ +0.01000.000.00
ESP32S20⚠️ +960.00⚠️ +0.01000.000.00
ESP32C30⚠️ +1080.00⚠️ +0.01000.000.00
ESP32C60⚠️ +1080.00⚠️ +0.01000.000.00
ESP320⚠️ +920.00⚠️ +0.01000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32S3ESP32S2ESP32C3ESP32C6ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
DNSServer/examples/CaptivePortal⚠️ +880⚠️ +960⚠️ +1080⚠️ +1080⚠️ +920

Copy link
Contributor

github-actions bot commented Sep 22, 2024

Test Results

 56 files   - 83   56 suites   - 83   4m 26s ⏱️ - 32m 23s
 21 tests  - 13   21 ✅ ± 0  0 💤 ±0  0 ❌ ±0 
135 runs   - 98  135 ✅  - 35  0 💤 ±0  0 ❌ ±0 

Results for commit a7c21df. ± Comparison against base commit 7018cd1.

This pull request removes 13 tests.
performance.coremark.test_coremark ‑ test_coremark
performance.fibonacci.test_fibonacci ‑ test_fibonacci
performance.psramspeed.test_psramspeed ‑ test_psramspeed
performance.ramspeed.test_ramspeed ‑ test_ramspeed
performance.superpi.test_superpi ‑ test_superpi
test_touch_errors
test_touch_interrtupt
test_touch_read
validation.periman.test_periman ‑ test_periman
validation.timer.test_timer ‑ test_timer
…

♻️ This comment has been updated with latest results.

@vortigont vortigont changed the title DNSServer: fix improper startup code in WiFi mode fix: DNSServer Lib - improper startup code in WiFi mode Sep 22, 2024
@me-no-dev me-no-dev added the Status: Pending Merge Pull Request is ready to be merged label Sep 25, 2024
@me-no-dev me-no-dev merged commit b05f18d into espressif:master Sep 25, 2024
40 checks passed
@me-no-dev
Copy link
Member

Thanks @vortigont for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DNS captive portal example works for android in release 2.0.17, but not in 3.x
2 participants