-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: DNSServer Lib - improper startup code in WiFi mode #10366
Conversation
When running on WiFi-AP mode server's start() method returned true while in fact UDP listening socket was never created Regression introduced in espressif#8760 Closes espressif#10330
👋 Hello vortigont, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
Test Results 56 files - 83 56 suites - 83 4m 26s ⏱️ - 32m 23s Results for commit a7c21df. ± Comparison against base commit 7018cd1. This pull request removes 13 tests.
♻️ This comment has been updated with latest results. |
Thanks @vortigont for the fix! |
When running on WiFi-AP mode server's start() method returned true while in fact UDP listening socket was never created
Regression introduced in #8760
Closes #10330