Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(esp32p4): Fix compilation errors #10371

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
772 changes: 385 additions & 387 deletions cores/esp32/esp32-hal-i2c-slave.c

Large diffs are not rendered by default.

7 changes: 5 additions & 2 deletions cores/esp32/esp32-hal-spi.c
Original file line number Diff line number Diff line change
Expand Up @@ -148,13 +148,15 @@ struct spi_struct_t {
#if CONFIG_DISABLE_HAL_LOCKS
#define SPI_MUTEX_LOCK()
#define SPI_MUTEX_UNLOCK()
+ static spi_t _spi_bus_array[] = {
// clang-format off
static spi_t _spi_bus_array[] = {
#if CONFIG_IDF_TARGET_ESP32S2
{(volatile spi_dev_t *)(DR_REG_SPI1_BASE), 0, -1, -1, -1, -1},
{(volatile spi_dev_t *)(DR_REG_SPI2_BASE), 1, -1, -1, -1, -1},
{(volatile spi_dev_t *)(DR_REG_SPI3_BASE), 2, -1, -1, -1, -1}
#elif CONFIG_IDF_TARGET_ESP32S3 || CONFIG_IDF_TARGET_ESP32P4
{(volatile spi_dev_t *)(DR_REG_SPI2_BASE), 0, -1, -1, -1, -1}, {(volatile spi_dev_t *)(DR_REG_SPI3_BASE), 1, -1, -1, -1, -1}
{(volatile spi_dev_t *)(DR_REG_SPI2_BASE), 0, -1, -1, -1, -1},
{(volatile spi_dev_t *)(DR_REG_SPI3_BASE), 1, -1, -1, -1, -1}
#elif CONFIG_IDF_TARGET_ESP32C2
{(volatile spi_dev_t *)(DR_REG_SPI2_BASE), 0, -1, -1, -1, -1}
#elif CONFIG_IDF_TARGET_ESP32C3
Expand All @@ -168,6 +170,7 @@ struct spi_struct_t {
{(volatile spi_dev_t *)(DR_REG_SPI3_BASE), 3, -1, -1, -1, -1}
#endif
};
// clang-format on
#else
#define SPI_MUTEX_LOCK() \
do { \
Expand Down
2 changes: 1 addition & 1 deletion cores/esp32/esp32-hal-touch.c
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
#if SOC_TOUCH_SENSOR_VERSION == 1 // ESP32
static uint16_t __touchSleepCycles = 0x1000;
static uint16_t __touchMeasureCycles = 0x1000;
#elif SOC_TOUCH_SENSOR_VERSION == 2 // ESP32S2, ESP32S3
#elif SOC_TOUCH_SENSOR_VERSION >= 2 // ESP32S2, ESP32S3, ESP32P4
static uint16_t __touchSleepCycles = TOUCH_PAD_SLEEP_CYCLE_DEFAULT;
static uint16_t __touchMeasureCycles = TOUCH_PAD_MEASURE_CYCLE_DEFAULT;
#endif
Expand Down
1 change: 1 addition & 0 deletions libraries/BLE/examples/BLE5_multi_advertising/ci.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"targets": {
"esp32": false,
"esp32p4": false,
"esp32s2": false
}
Expand Down
5 changes: 1 addition & 4 deletions libraries/BLE/examples/BLE5_periodic_advertising/ci.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
{
"targets": {
"esp32": false,
"esp32c2": false,
"esp32c3": false,
"esp32p4": false,
"esp32s2": false,
"esp32s3": false
"esp32s2": false
}
}
3 changes: 0 additions & 3 deletions libraries/BLE/examples/BLE5_periodic_sync/ci.json
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
{
"targets": {
"esp32": false,
"esp32c3": false,
"esp32c6": false,
"esp32h2": false,
"esp32p4": false,
"esp32s2": false
}
Expand Down
3 changes: 0 additions & 3 deletions libraries/BLE/examples/Beacon_Scanner/ci.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
{
"targets": {
"esp32c3": false,
"esp32c6": false,
"esp32h2": false,
"esp32p4": false,
"esp32s2": false
}
Expand Down
1 change: 0 additions & 1 deletion libraries/BLE/examples/Client/ci.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{
"targets": {
"esp32c3": false,
"esp32p4": false,
"esp32s2": false
}
Expand Down
1 change: 0 additions & 1 deletion libraries/BLE/examples/Notify/ci.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{
"targets": {
"esp32h2": false,
"esp32p4": false,
"esp32s2": false
}
Expand Down
6 changes: 1 addition & 5 deletions libraries/BLE/examples/Server/ci.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
{
"targets": {
"esp32": false,
"esp32c2": false,
"esp32c3": false,
"esp32p4": false,
"esp32s2": false,
"esp32s3": false
"esp32s2": false
}
}
4 changes: 0 additions & 4 deletions libraries/BLE/examples/Server_multiconnect/ci.json
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
{
"targets": {
"esp32": false,
"esp32c3": false,
"esp32c6": false,
"esp32h2": false,
"esp32p4": false,
"esp32s2": false
}
Expand Down
3 changes: 0 additions & 3 deletions libraries/BLE/examples/UART/ci.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
{
"targets": {
"esp32c3": false,
"esp32c6": false,
"esp32h2": false,
"esp32p4": false,
"esp32s2": false
}
Expand Down
1 change: 0 additions & 1 deletion libraries/BLE/examples/Write/ci.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{
"targets": {
"esp32c3": false,
"esp32p4": false,
"esp32s2": false
}
Expand Down
1 change: 0 additions & 1 deletion libraries/BLE/examples/iBeacon/ci.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{
"targets": {
"esp32h2": false,
"esp32p4": false,
"esp32s2": false
}
Expand Down
3 changes: 2 additions & 1 deletion libraries/ESP32/examples/DeepSleep/TouchWakeUp/ci.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"targets": {
"esp32c3": false,
"esp32c6": false,
"esp32h2": false
"esp32h2": false,
"esp32p4": false
}
}
1 change: 1 addition & 0 deletions libraries/ESP32/examples/Touch/TouchButton/ci.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"esp32c3": false,
"esp32c6": false,
"esp32h2": false,
"esp32p4": false,
"esp32s2": false,
"esp32s3": false
}
Expand Down
3 changes: 2 additions & 1 deletion libraries/ESP32/examples/Touch/TouchButtonV2/ci.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"esp32": false,
"esp32c3": false,
"esp32c6": false,
"esp32h2": false
"esp32h2": false,
"esp32p4": false
}
}
3 changes: 2 additions & 1 deletion libraries/ESP32/examples/Touch/TouchInterrupt/ci.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"targets": {
"esp32c3": false,
"esp32c6": false,
"esp32h2": false
"esp32h2": false,
"esp32p4": false
}
}
3 changes: 2 additions & 1 deletion libraries/ESP32/examples/Touch/TouchRead/ci.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"targets": {
"esp32c3": false,
"esp32c6": false,
"esp32h2": false
"esp32h2": false,
"esp32p4": false
}
}
1 change: 1 addition & 0 deletions libraries/Ethernet/examples/ETH_LAN8720/ci.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"esp32c3": false,
"esp32c6": false,
"esp32h2": false,
"esp32p4": false,
"esp32s2": false,
"esp32s3": false
}
Expand Down
1 change: 1 addition & 0 deletions libraries/Ethernet/examples/ETH_TLK110/ci.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"esp32c3": false,
"esp32c6": false,
"esp32h2": false,
"esp32p4": false,
"esp32s2": false,
"esp32s3": false
}
Expand Down
6 changes: 3 additions & 3 deletions libraries/OpenThread/examples/COAP/coap_switch/ci.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"targets": {
"esp32": false,
"esp32c2": false,
"esp32c3": false,
"esp32c6": false,
"esp32h2": false,
"esp32p4": false,
"esp32s2": false
"esp32s2": false,
"esp32s3": false
}
}
7 changes: 4 additions & 3 deletions libraries/OpenThread/examples/SimpleCLI/ci.json
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
{
"targets": {
"esp32": false,
"esp32c2": false,
"esp32c3": false,
"esp32c6": false,
"esp32h2": false,
"esp32p4": false,
"esp32s2": false
"esp32s2": false,
"esp32s3": false
}
}
5 changes: 4 additions & 1 deletion libraries/OpenThread/examples/SimpleNode/ci.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
{
"targets": {
"esp32": false,
"esp32c2": false,
"esp32c3": false,
"esp32p4": false,
"esp32s2": false
"esp32s2": false,
"esp32s3": false
}
}
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
{
"targets": {
"esp32h2": false,
"esp32": false,
"esp32c2": false,
"esp32c3": false,
"esp32p4": false,
"esp32s2": false
"esp32s2": false,
"esp32s3": false
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
#define HSPI_SS 15
#endif

#if CONFIG_IDF_TARGET_ESP32S2 || CONFIG_IDF_TARGET_ESP32S3
#if CONFIG_IDF_TARGET_ESP32S2 || CONFIG_IDF_TARGET_ESP32S3 || CONFIG_IDF_TARGET_ESP32P4
#define VSPI FSPI
#endif

Expand Down
3 changes: 3 additions & 0 deletions tests/validation/periman/ci.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,8 @@
"platforms": {
"qemu": false,
"wokwi": false
},
"targets": {
"esp32p4": false
}
}
3 changes: 2 additions & 1 deletion tests/validation/touch/ci.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
"targets": {
"esp32c3": false,
"esp32c6": false,
"esp32h2": false
"esp32h2": false,
"esp32p4": false
}
}
24 changes: 12 additions & 12 deletions tests/validation/uart/uart.ino
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ void transmit_and_check_msg(const String msg_append, bool perform_assert = true)
if (perform_assert) {
TEST_ASSERT_EQUAL_STRING(("Hello from Serial1 (UART1) >>> via loopback >>> Serial1 (UART1) " + msg_append).c_str(), recv_msg.c_str());
}
#elif SOC_UART_HP_NUM == 3
#elif SOC_UART_HP_NUM >= 3
Serial1.print("Hello from Serial1 (UART1) >>> to >>> Serial2 (UART2) " + msg_append);
Serial1.flush();
delay(100);
Expand Down Expand Up @@ -128,7 +128,7 @@ void task_delayed_msg(void *pvParameters) {

#if SOC_UART_HP_NUM == 2
selected_serial = &Serial;
#elif SOC_UART_HP_NUM == 3
#elif SOC_UART_HP_NUM >= 3
selected_serial = &Serial1;
#endif

Expand All @@ -150,7 +150,7 @@ void setUp(void) {
onReceive_cb(Serial1);
});
uart_internal_loopback(1, RX1);
#elif SOC_UART_HP_NUM == 3
#elif SOC_UART_HP_NUM >= 3
log_d("Setup internal loop-back between Serial1 (UART1) <<--->> Serial2 (UART2)");

Serial1.onReceive([]() {
Expand Down Expand Up @@ -225,7 +225,7 @@ void change_baudrate_test(void) {
Serial1.updateBaudRate(9600);
TEST_ASSERT_UINT_WITHIN(192, 9600, Serial1.baudRate());

#if SOC_UART_HP_NUM == 3
#if SOC_UART_HP_NUM >= 3
Serial2.updateBaudRate(9600);
TEST_ASSERT_UINT_WITHIN(192, 9600, Serial2.baudRate());
#endif
Expand All @@ -239,7 +239,7 @@ void change_baudrate_test(void) {
//Baudrate error should be within 2% of the target baudrate
TEST_ASSERT_UINT_WITHIN(2304, 115200, Serial1.baudRate());

#if SOC_UART_HP_NUM == 3
#if SOC_UART_HP_NUM >= 3
TEST_ASSERT_UINT_WITHIN(2304, 115200, Serial2.baudRate());
#endif

Expand Down Expand Up @@ -421,7 +421,7 @@ void change_pins_test(void) {

#if SOC_UART_HP_NUM == 2
esp_rom_gpio_connect_out_signal(SOC_RX0, SIG_GPIO_OUT_IDX, false, false);
#elif SOC_UART_HP_NUM == 3
#elif SOC_UART_HP_NUM >= 3
esp_rom_gpio_connect_out_signal(RX1, SIG_GPIO_OUT_IDX, false, false);
esp_rom_gpio_connect_out_signal(RX2, SIG_GPIO_OUT_IDX, false, false);
#endif
Expand All @@ -432,7 +432,7 @@ void change_pins_test(void) {
Serial1.setPins(NEW_RX1, NEW_TX1);
TEST_ASSERT_EQUAL(NEW_RX1, uart_get_RxPin(1));
TEST_ASSERT_EQUAL(NEW_TX1, uart_get_TxPin(1));
#elif SOC_UART_HP_NUM == 3
#elif SOC_UART_HP_NUM >= 3
Serial1.setPins(RX2, TX2);
Serial2.setPins(RX1, TX1);
TEST_ASSERT_EQUAL(RX2, uart_get_RxPin(1));
Expand All @@ -447,7 +447,7 @@ void change_pins_test(void) {

#if SOC_UART_HP_NUM == 2
uart_internal_loopback(1, NEW_RX1);
#elif SOC_UART_HP_NUM == 3
#elif SOC_UART_HP_NUM >= 3
uart_internal_loopback(1, RX1);
uart_internal_loopback(2, RX2);
#endif
Expand All @@ -470,7 +470,7 @@ void auto_baudrate_test(void) {
#if SOC_UART_HP_NUM == 2
selected_serial = &Serial1;
uart_internal_loopback(0, RX1);
#elif SOC_UART_HP_NUM == 3
#elif SOC_UART_HP_NUM >= 3
selected_serial = &Serial2;
#endif

Expand Down Expand Up @@ -504,7 +504,7 @@ void periman_test(void) {

Wire.begin(RX1, TX1);

#if SOC_UART_HP_NUM == 3
#if SOC_UART_HP_NUM >= 3
Wire1.begin(RX2, TX2);
#endif

Expand All @@ -518,7 +518,7 @@ void periman_test(void) {

Serial1.setPins(RX1, TX1);

#if SOC_UART_HP_NUM == 3
#if SOC_UART_HP_NUM >= 3
Serial2.setPins(RX2, TX2);
uart_internal_loopback(1, RX2);
uart_internal_loopback(2, RX1);
Expand Down Expand Up @@ -577,7 +577,7 @@ void setup() {
onReceive_cb(Serial1);
});
uart_internal_loopback(1, RX1);
#elif SOC_UART_HP_NUM == 3
#elif SOC_UART_HP_NUM >= 3
log_d("Setup internal loop-back between Serial1 (UART1) <<--->> Serial2 (UART2)");

Serial1.onReceive([]() {
Expand Down
3 changes: 2 additions & 1 deletion tests/validation/wifi/ci.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
"qemu": false
},
"targets": {
"esp32h2": false
"esp32h2": false,
"esp32p4": false
}
}
Loading
Loading