Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WPS example config initialization #10399

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Fix WPS example config initialization #10399

merged 2 commits into from
Oct 2, 2024

Conversation

me-no-dev
Copy link
Member

It causes errors with newer C++ standarts

cc: @SuGlider

Copy link
Contributor

github-actions bot commented Oct 2, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "fix(wps): adds memset to 0":
    • summary looks too short

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello me-no-dev, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 585022e

Copy link
Contributor

github-actions bot commented Oct 2, 2024

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32S3💚 -1080💚 -0.010.00000.000.00
ESP32S2💚 -1000💚 -0.010.00000.000.00
ESP32C3💚 -740💚 -0.010.00000.000.00
ESP32C6💚 -740💚 -0.010.00000.000.00
ESP32💚 -1080💚 -0.010.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32S3ESP32S2ESP32C3ESP32C6ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
WiFi/examples/WPS💚 -1080💚 -1000💚 -740💚 -740💚 -1080

Copy link
Contributor

github-actions bot commented Oct 2, 2024

Test Results

 41 files   -  74   41 suites   - 74   3m 12s ⏱️ - 1h 33m 8s
 19 tests  -   6   19 ✅  -   5  0 💤 ±0  0 ❌  - 1 
120 runs   - 153  120 ✅  - 152  0 💤 ±0  0 ❌  - 1 

Results for commit 585022e. ± Comparison against base commit 84ddf0a.

This pull request removes 6 tests.
performance.coremark.test_coremark ‑ test_coremark
performance.fibonacci.test_fibonacci ‑ test_fibonacci
performance.psramspeed.test_psramspeed ‑ test_psramspeed
performance.ramspeed.test_ramspeed ‑ test_ramspeed
performance.superpi.test_superpi ‑ test_superpi
validation.periman.test_periman ‑ test_periman

♻️ This comment has been updated with latest results.

@me-no-dev me-no-dev added the Status: Pending Merge Pull Request is ready to be merged label Oct 2, 2024
@me-no-dev me-no-dev merged commit cd97131 into master Oct 2, 2024
54 checks passed
@me-no-dev me-no-dev deleted the bugfix/wps_ino branch October 2, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants