Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add our new board "cezerio dev ESP32C6" #10462

Merged
merged 21 commits into from
Oct 17, 2024
Merged

Conversation

DogushC
Copy link
Contributor

@DogushC DogushC commented Oct 15, 2024

Description of Change

cezerio dev ESP32C6 is an development board based on ESP32-C6. Infos were added into "board.txt" and "variants\cezerio_dev_esp32c6\pins_arduino.h" files.

Tests scenarios

We tested it with Arduino IDE by manually adding cezerio dev ESP32C6 files in Arduino ESP32 repo.

Related links

Our website is under construction.

@CLAassistant
Copy link

CLAassistant commented Oct 15, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

github-actions bot commented Oct 15, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Add cezerio dev ESP32-C6":
    • summary looks empty
    • type/action looks empty
  • the commit message "Add cezerio dev ESP32-C6":
    • summary looks empty
    • type/action looks empty
  • the commit message "Add cezerio dev ESP32C6":
    • summary looks empty
    • type/action looks empty
  • the commit message "Merge manually to solve conflicts":
    • summary looks empty
    • type/action looks empty
  • the commit message "Modify pin number of cezerio dev ESP32C6":
    • summary looks empty
    • type/action looks empty
  • the commit message "Modify pin number of cezerio dev ESP32C6":
    • summary looks empty
    • type/action looks empty
  • the commit message "Resolve Conflicts":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update USB_PID":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update USB_PID":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update boards.txt":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update boards.txt":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update boards.txt":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update pins_arduino.h":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update pins_arduino.h":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update pins_arduino.h":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update pins_arduino.h":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update pins_arduino.h":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

⚠️ Please consider squashing your 21 commits (simplifying branch history).

👋 Hello DogushC, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 9b0e9dc

@P-R-O-C-H-Y P-R-O-C-H-Y added the Resolution: Awaiting response Waiting for response of author label Oct 16, 2024
Deleted flash and partition options related in flash size bigger than 4MB
@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Pending Merge Pull Request is ready to be merged and removed Resolution: Awaiting response Waiting for response of author labels Oct 16, 2024
@me-no-dev
Copy link
Member

Please make the following changes to fix the style https://github.com/espressif/arduino-esp32/actions/runs/11367159783/job/31619211893?pr=10462#step:8:40

Also you need to fix the merge conflicts

@DogushC
Copy link
Contributor Author

DogushC commented Oct 17, 2024

Please make the following changes to fix the style https://github.com/espressif/arduino-esp32/actions/runs/11367159783/job/31619211893?pr=10462#step:8:40

Also you need to fix the merge conflicts

@me-no-dev it is done.

@me-no-dev me-no-dev merged commit 51b2fb3 into espressif:master Oct 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants