-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(zigbee): Enable the internal pull-up resistor for BUTTON_PIN #10491
Conversation
👋 Hello lboue, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
Test Results 56 files 56 suites 4m 9s ⏱️ Results for commit d556fab. ♻️ This comment has been updated with latest results. |
Enable the internal pull-up resistor for BUTTON_PIN
@P-R-O-C-H-Y PTAL |
Description of Change
Configure
BUTTON_PIN
/SWITCH_PIN
as an input and enable the internal pull-up resistor.I am facing a factory reset loop using a Waveshare ESP32-H2-DEV-KIT-N4 board witout enabling pull-up.
Tests scenarios
I tested this with :
Waveshare ESP32-H2-DEV-KIT-N4 board
ESP32-C6-WROOM-1 board
Related links
Please provide links to related issue, PRs etc.