fix(IPaddress): IPv6 restore zone id #10546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR restores the IPv6 zone-id in String representation of IPv6 address as well as parsing. This follows espressif@20a28b5 that disabled it due to a crash in `netif_index_to_name()`. The fixed code scans through `netif_list` to find the `netif` name and id. Note: zone-id are incremented by 1 compared to `netif` id. For example internal zoneid value `3` actually translates to `%st2`
👋 Hello s-hadinger, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
Test Results 62 files 62 suites 16m 33s ⏱️ For more details on these failures, see this check. Results for commit a750bdb. ♻️ This comment has been updated with latest results. |
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
me-no-dev
approved these changes
Oct 30, 2024
VojtechBartoska
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restores the IPv6 zone-id in String representation of IPv6 address as well as parsing. This follows 20a28b5 that disabled it due to a crash in netif_index_to_name()
Checklist
This entire section above can be deleted if all items are checked.
Description of Change
This PR restores the IPv6 zone-id in String representation of IPv6 address as well as parsing. This follows 20a28b5 that disabled it due to a crash in
netif_index_to_name().The fixed code scans through
netif_listto find thenetifname and id.Note: zone-id are incremented by 1 compared to
netifid.For example internal zoneid value
3actually translates to%st2Tests scenarios
Related links
20a28b5