Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Split provisioning into two parts for better synchronization #10677

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

kvp1703
Copy link
Contributor

@kvp1703 kvp1703 commented Dec 4, 2024

Description of Change

Split provisioning into two parts for better synchronization.
The user node association (cloud_user_assoc) endpoint failed to register in the provisioning workflow because provisioning began before the endpoint creation.

@CLAassistant
Copy link

CLAassistant commented Dec 4, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Warnings
⚠️
	The **target branch** for this Pull Request **must be the default branch** of the project (`master`).

	If you would like to add this feature to a different branch, please state this in the PR description and we will consider it.

👋 Hello kvp1703, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 4ecfd35

@kvp1703 kvp1703 changed the base branch from release/v3.1.x to master December 4, 2024 06:05
@kvp1703 kvp1703 changed the base branch from master to release/v3.1.x December 4, 2024 06:06
@kvp1703 kvp1703 force-pushed the fix/wifi_provision branch from 1d068ae to f2c9ad9 Compare December 4, 2024 06:47
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Test Results

 62 files   62 suites   5m 42s ⏱️
 21 tests  21 ✅ 0 💤 0 ❌
154 runs  154 ✅ 0 💤 0 ❌

Results for commit 4ecfd35.

♻️ This comment has been updated with latest results.

@kvp1703 kvp1703 force-pushed the fix/wifi_provision branch from f2c9ad9 to 2c9e8c2 Compare December 4, 2024 08:52
@kvp1703 kvp1703 force-pushed the fix/wifi_provision branch from 2c9e8c2 to 4eeff9b Compare December 4, 2024 09:35
Copy link
Contributor

github-actions bot commented Dec 5, 2024

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32S30‼️ +20K0.00‼️ +1.080‼️ +4K0.00‼️ +6.53
ESP32S2💚 -14K0💚 -1.460.000‼️ +3K0.00‼️ +7.35
ESP32C30‼️ +35K0.00‼️ +1.790⚠️ +20240.00‼️ +3.66
ESP32C60‼️ +49K0.00‼️ +2.390‼️ +25K0.00‼️ +39.41
ESP320‼️ +10K0.00⚠️ +0.510⚠️ +13840.00‼️ +2.41
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32S3ESP32S2ESP32C3ESP32C6ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
RainMaker/examples/RMakerSwitch‼️ +20K‼️ +3K💚 -9K⚠️ +1828‼️ +35K⚠️ +1880‼️ +49K‼️ +25K‼️ +10K⚠️ +480
WiFiProv/examples/WiFiProv‼️ +15K‼️ +4K💚 -14K‼️ +3K‼️ +26K⚠️ +2024‼️ +41K‼️ +3K‼️ +6K⚠️ +1384

@SuGlider SuGlider self-requested a review December 11, 2024 13:42
@SuGlider SuGlider added this to the 3.1.0 milestone Dec 11, 2024
@SuGlider SuGlider added the Status: Pending Merge Pull Request is ready to be merged label Dec 11, 2024
@me-no-dev me-no-dev merged commit 59d51de into espressif:release/v3.1.x Dec 11, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged
Projects
Development

Successfully merging this pull request may close these issues.

5 participants