-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/include order #10841
Bugfix/include order #10841
Conversation
👋 Hello SuGlider, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Test Results 62 files 62 suites 5m 42s ⏱️ Results for commit 63cb1e2. ♻️ This comment has been updated with latest results. |
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
Fix, does work. Thx. |
Description of Change
The PR #10128 has added
RGB_BUILTIN_LED_COLOR_ORDER
as a possible parameter for RGB LED writing function.There is an issue with the include order.
cores/esp32/esp32-hal-rgb-led.h
shall receiveRGB_BUILTIN_LED_COLOR_ORDER
fromvariants/lolin_s3_min/pins_arduino.h
and do not modify it in case it is already defined.But there are a few places where the include order is
esp-hal.h
first and latterpins_arduino.h
.Given that
esp-hal.h
includesesp32-hal-rgb-led.h
this cases a warning as error:pins_arduino.h:17: error: "RGB_BUILTIN_LED_COLOR_ORDER" redefined
Tests scenarios
Using Examples->ESP32->GPIO->BlinkRGB.ino + lolin_s3_mini board
Related links
Fixes #10822