-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(board): Update feathers3 wire1 pin definition #11001
Conversation
👋 Hello ericlewis, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
@ericlewis please sign CLA :) |
@UnexpectedMaker PTAL |
@me-no-dev signed! |
Based on https://esp32s3.com/feathers3.html#pins - it seems fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes
Checklist
This entire section above can be deleted if all items are checked.
Description of Change
Please describe your proposed Pull Request and it's impact.
add wire1 definition
Tests scenarios
Please describe on what Hardware and Software combinations you have tested this Pull Request and how.
feathers3 rev 8 from unexpected maker
Related links
Please provide links to related issue, PRs etc.
(eg. Closes #number of issue)