Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(board): Update feathers3 wire1 pin definition #11001

Merged
merged 3 commits into from
Feb 25, 2025

Conversation

ericlewis
Copy link
Contributor

By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes

Checklist

  1. Please provide specific title of the PR describing the change, including the component name (eg. „Update of Documentation link on Readme.md“)
  2. Please provide related links (eg. Issue which will be closed by this Pull Request)
  3. Please update relevant Documentation if applicable
  4. Please check Contributing guide
  5. Please confirm option to "Allow edits and access to secrets by maintainers" when opening a Pull Request

This entire section above can be deleted if all items are checked.


Description of Change

Please describe your proposed Pull Request and it's impact.
add wire1 definition

Tests scenarios

Please describe on what Hardware and Software combinations you have tested this Pull Request and how.
feathers3 rev 8 from unexpected maker

Related links

Please provide links to related issue, PRs etc.

(eg. Closes #number of issue)

@CLAassistant
Copy link

CLAassistant commented Feb 21, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

github-actions bot commented Feb 21, 2025

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "update feathers3 wire1 pin definition":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello ericlewis, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 5779ef1

@P-R-O-C-H-Y P-R-O-C-H-Y changed the title update feathers3 wire1 pin definition fix(boards): Update feathers3 wire1 pin definition Feb 21, 2025
@P-R-O-C-H-Y P-R-O-C-H-Y changed the title fix(boards): Update feathers3 wire1 pin definition fix(board): Update feathers3 wire1 pin definition Feb 21, 2025
@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Pending Merge Pull Request is ready to be merged label Feb 21, 2025
@me-no-dev me-no-dev added Status: Pending CLA ⚠️ Contributor is required to sign the CLA and removed Status: Pending Merge Pull Request is ready to be merged labels Feb 21, 2025
@me-no-dev
Copy link
Member

@ericlewis please sign CLA :)

@me-no-dev
Copy link
Member

@UnexpectedMaker PTAL

@ericlewis
Copy link
Contributor Author

@me-no-dev signed!

@SuGlider SuGlider removed the Status: Pending CLA ⚠️ Contributor is required to sign the CLA label Feb 23, 2025
@SuGlider
Copy link
Collaborator

Based on https://esp32s3.com/feathers3.html#pins - it seems fine.

image

@SuGlider SuGlider self-requested a review February 23, 2025 17:06
Copy link
Collaborator

@SuGlider SuGlider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuGlider SuGlider added the Status: Pending Merge Pull Request is ready to be merged label Feb 23, 2025
@me-no-dev me-no-dev merged commit 164fcc6 into espressif:master Feb 25, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants