Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(zigbee): Add ZigbeeGateway endpoint support + Time Cluster bugfix #11009

Merged
merged 9 commits into from
Feb 26, 2025
Merged

feat(zigbee): Add ZigbeeGateway endpoint support + Time Cluster bugfix #11009

merged 9 commits into from
Feb 26, 2025

Conversation

P-R-O-C-H-Y
Copy link
Member

Description of Change

This PR adds support for Zigbee Gateway which demonstrates using Zigbee on chips without Zigbee radio, which communicates using UART to another ESP32 (C6/H2) that acts as a radio co-processor (provides the Zigbee radio).

Also this PR contains a Bugfix for the TimeCluster, which was missing the mandatory time_status attribute.

Tests scenarios

Tested using ESP32-S3 (running Zigbee_Gateway example) connected to ESP32-C6 (running ot_rcp example).

ESP32S3 pin ESP32-C6 pin
GND G
GPIO4 (RX) TX
GPIO5 (TX) RX

Related links

@P-R-O-C-H-Y P-R-O-C-H-Y added the Area: Zigbee Issues and Feature Request about Zigbee label Feb 25, 2025
@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Feb 25, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 25, 2025 •
edited
Loading

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "feaz(zigbee): Update keywords.txt with latest updates":
    • type/action should be one of [change, ci, docs, feat, fix, refactor, remove, revert, test]

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello P-R-O-C-H-Y, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 43aef6c

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 25, 2025 •
edited
Loading

Test Results

 80 files   80 suites   11m 25s ⏱️
 37 tests  37 ✅ 0 💤 0 ❌
233 runs  233 ✅ 0 💤 0 ❌

Results for commit 43aef6c.

♻️ This comment has been updated with latest results.

@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Review needed Issue or PR is awaiting review label Feb 25, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 25, 2025 •
edited
Loading

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32S30‼️ +23K0.00‼️ +3.770⚠️ +3120.00⚠️ +0.85
ESP32S20‼️ +23K0.00‼️ +4.020⚠️ +3120.00⚠️ +0.99
ESP32C30‼️ +26K0.00‼️ +4.120⚠️ +3280.00‼️ +1.15
ESP32C60‼️ +26K0.00‼️ +5.040⚠️ +3360.00‼️ +1.17
ESP32H20‼️ +26K0.00‼️ +4.910⚠️ +3360.00‼️ +1.21
ESP320‼️ +23K0.00‼️ +3.870⚠️ +3120.00⚠️ +0.86
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32S3ESP32S2ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
Zigbee/examples/Zigbee_Color_Dimmer_Switch‼️ +15K⚠️ +232‼️ +15K⚠️ +232‼️ +16K⚠️ +240‼️ +16K⚠️ +248‼️ +16K⚠️ +248‼️ +15K⚠️ +224
Zigbee/examples/Zigbee_Gateway------------
Zigbee/examples/Zigbee_On_Off_Switch‼️ +13K⚠️ +232‼️ +13K⚠️ +232‼️ +14K⚠️ +240‼️ +14K⚠️ +256‼️ +14K⚠️ +240‼️ +13K⚠️ +232
Zigbee/examples/Zigbee_Range_Extender‼️ +23K⚠️ +312‼️ +23K⚠️ +312‼️ +26K⚠️ +328‼️ +26K⚠️ +328‼️ +26K⚠️ +320‼️ +23K⚠️ +312
Zigbee/examples/Zigbee_Thermostat‼️ +19K⚠️ +264‼️ +19K⚠️ +264‼️ +21K⚠️ +296‼️ +21K⚠️ +288‼️ +21K⚠️ +272‼️ +19K⚠️ +264
Zigbee/examples/Zigbee_Analog_Input_Output------‼️ +26K⚠️ +328‼️ +26K⚠️ +336--
Zigbee/examples/Zigbee_CarbonDioxide_Sensor------‼️ +26K⚠️ +328‼️ +26K⚠️ +336--
Zigbee/examples/Zigbee_Color_Dimmable_Light------‼️ +12K⚠️ +200‼️ +12K⚠️ +192--
Zigbee/examples/Zigbee_Contact_Switch------‼️ +23K⚠️ +304‼️ +23K⚠️ +296--
Zigbee/examples/Zigbee_Dimmable_Light------‼️ +12K⚠️ +224‼️ +12K⚠️ +224--
Zigbee/examples/Zigbee_OTA_Client------‼️ +14K⚠️ +256‼️ +14K⚠️ +240--
Zigbee/examples/Zigbee_Occupancy_Sensor------‼️ +26K⚠️ +336‼️ +26K⚠️ +328--
Zigbee/examples/Zigbee_On_Off_Light------‼️ +14K⚠️ +248‼️ +14K⚠️ +248--
Zigbee/examples/Zigbee_Pressure_Flow_Sensor------‼️ +26K⚠️ +328‼️ +26K⚠️ +336--
Zigbee/examples/Zigbee_Scan_Networks------0000--
Zigbee/examples/Zigbee_Temp_Hum_Sensor_Sleepy------‼️ +26K⚠️ +328‼️ +26K⚠️ +336--
Zigbee/examples/Zigbee_Temperature_Sensor------‼️ +26K⚠️ +320‼️ +26K⚠️ +328--
Zigbee/examples/Zigbee_Vibration_Sensor------‼️ +23K⚠️ +304‼️ +23K⚠️ +296--
Zigbee/examples/Zigbee_Window_Covering------‼️ +21K⚠️ +256‼️ +21K⚠️ +240--

@SuGlider SuGlider added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Feb 25, 2025
@me-no-dev me-no-dev merged commit 923da95 into espressif:master Feb 26, 2025
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@me-no-dev me-no-dev me-no-dev approved these changes

@lucasssvaz lucasssvaz lucasssvaz approved these changes

@SuGlider SuGlider SuGlider approved these changes

Assignees

@P-R-O-C-H-Y P-R-O-C-H-Y

Labels
Area: Zigbee Issues and Feature Request about Zigbee Status: Pending Merge Pull Request is ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@P-R-O-C-H-Y @me-no-dev @lucasssvaz @SuGlider