-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bt): Compile error on ESP32-P4 #11035
Conversation
👋 Hello iranl, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Test Results 76 files 76 suites 11m 57s ⏱️ Results for commit 494b436. ♻️ This comment has been updated with latest results. |
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
Tnx for the reviews Actually noticed just now I made an error. Both changed lines should be:
NOT
|
Description of Change
My project uses Arduino as an ESP-IDF component with esp-nimble-cpp to provide BLE functionality
I'm seeing compile errors when trying to build my project for the ESP32-P4 because of missing
esp_bt.h
and (as a result) not definedesp_bt_controller_mem_release
andESP_BT_MODE_BTDM
.As far as I can see
cores/esp32/esp32-hal-misc.c
is the only place where inclusion ofesp_bt.h
is not guarded by#if SOC_BT_SUPPORTED
This PR fixes these errors.
Tests scenarios
I have tested compilation of my Pull Request on Arduino-esp32 core v3.1.3 with ESP32-P4 Board with this scenario
Related links
None