Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eth): Fix RMII Ethernet not being able to be restarted #11048

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

me-no-dev
Copy link
Member

This pull request includes changes to the ETHClass::begin method in the libraries/Ethernet/src/ETH.cpp file. The main purpose of these changes is to improve the initialization process of the Ethernet MAC and PHY by storing the created instances in class member variables instead of local variables.

Initialization improvements:

  • Changed the mac variable to a class member variable _mac and updated the error handling to use _mac.
  • Changed the phy variable to a class member variable _phy and updated the error handling to use _phy.
  • Updated the switch cases for different PHY types to assign the new PHY instances to _phy instead of phy.
  • Modified the eth_config initialization to use the class member variables _mac and _phy instead of the local variables mac and phy.

Copy link
Contributor

github-actions bot commented Mar 7, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello me-no-dev, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 5a710be

@me-no-dev me-no-dev added the Status: Review needed Issue or PR is awaiting review label Mar 7, 2025
Copy link
Contributor

github-actions bot commented Mar 7, 2025

Test Results

 76 files   76 suites   12m 43s ⏱️
 38 tests  38 ✅ 0 💤 0 ❌
241 runs  241 ✅ 0 💤 0 ❌

Results for commit 5a710be.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Mar 7, 2025

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32P40⚠️ +40.000.00000.000.00
ESP32S3000.000.00000.000.00
ESP32S2000.000.00000.000.00
ESP32C3000.000.00000.000.00
ESP32C6000.000.00000.000.00
ESP32H2000.000.00000.000.00
ESP32💚 -400.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32P4ESP32S3ESP32S2ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
Ethernet/examples/ETH_TLK110⚠️ +40----------💚 -40
Ethernet/examples/ETH_W5500_Arduino_SPI00000000000000
Ethernet/examples/ETH_W5500_IDF_SPI00000000000000
Ethernet/examples/ETH_WIFI_BRIDGE0000000000--00
Ethernet/examples/ETH_LAN8720------------💚 -40

Copy link
Collaborator

@SuGlider SuGlider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuGlider SuGlider added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Mar 10, 2025
@SuGlider SuGlider added this to the 3.2.0 milestone Mar 10, 2025
@me-no-dev me-no-dev merged commit 8575d04 into master Mar 10, 2025
67 of 76 checks passed
@me-no-dev me-no-dev deleted the bugfix/rmii_eth_end_begin branch March 10, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged
Projects
Development

Successfully merging this pull request may close these issues.

4 participants