Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(wifi): Disable properly LR mode if it was enabled before #11052

Merged
merged 2 commits into from
Mar 10, 2025
Merged

fix(wifi): Disable properly LR mode if it was enabled before #11052

merged 2 commits into from
Mar 10, 2025

Conversation

me-no-dev
Copy link
Member

WiFi LR mode is stored in NVS, so once enabled, there was no way to disabled it through Arduino. This pull request fixes that and disables LR mode if it was not selected to be enabled, but was enabled before.

This pull request also focuses on improving the error logging in the WiFiGeneric.cpp file by providing more detailed error messages using the esp_err_to_name function. The changes ensure that error codes are logged in hexadecimal format along with their corresponding error names.

Improvements to error logging:

  • Updated error logging in wifiLowLevelInit to include error names and codes in hexadecimal format.
  • Enhanced error logging in espWiFiStart and espWiFiStop to include error names and codes in hexadecimal format. [1] [2]
  • Improved error logging in WiFiGenericClass::setChannel to include error names and codes in hexadecimal format for both getting and setting the channel. [1] [2]
  • Added detailed error logging in WiFiGenericClass::mode for various operations including setting hostname, mode, and enabling/disabling long range. [1] [2]
  • Enhanced error logging in WiFiGenericClass::setSleep, initiateFTM, and setDualAntennaConfig to include error names and codes in hexadecimal format. [1] [2] [3] [4] [5]

@me-no-dev me-no-dev added Status: Review needed Issue or PR is awaiting review Area: WiFi Issue related to WiFi labels Mar 7, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2025 •
edited
Loading

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello me-no-dev, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against cafc1c6

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2025 •
edited
Loading

Test Results

 76 files   76 suites   12m 39s ⏱️
 38 tests  38 ✅ 0 💤 0 ❌
241 runs  241 ✅ 0 💤 0 ❌

Results for commit cafc1c6.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2025 •
edited
Loading

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32P40⚠️ +2820.00⚠️ +0.04000.000.00
ESP32S30⚠️ +4480.00⚠️ +0.05000.000.00
ESP32S20⚠️ +4640.00⚠️ +0.06000.000.00
ESP32C30⚠️ +4980.00⚠️ +0.05000.000.00
ESP32C60⚠️ +5200.00⚠️ +0.06000.000.00
ESP320⚠️ +5040.00⚠️ +0.06000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32P4ESP32S3ESP32S2ESP32C3ESP32C6ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
WiFi/examples/FTM/FTM_Initiator⚠️ +2760⚠️ +4320⚠️ +4480⚠️ +4940⚠️ +5180⚠️ +4720
WiFi/examples/FTM/FTM_Responder⚠️ +2800⚠️ +4480⚠️ +4440⚠️ +4960⚠️ +5180⚠️ +4920
WiFi/examples/SimpleWiFiServer⚠️ +2760⚠️ +4320⚠️ +4480⚠️ +4940⚠️ +5160⚠️ +4960
WiFi/examples/WiFiAccessPoint⚠️ +2740⚠️ +4320⚠️ +4400⚠️ +4940⚠️ +5180⚠️ +4960
WiFi/examples/WiFiClient⚠️ +2740⚠️ +4360⚠️ +4640⚠️ +4980⚠️ +5200⚠️ +4920
WiFi/examples/WiFiClientBasic⚠️ +2760⚠️ +3800⚠️ +4560⚠️ +4960⚠️ +5200⚠️ +4800
WiFi/examples/WiFiClientConnect⚠️ +2800⚠️ +4400⚠️ +4600⚠️ +4980⚠️ +5180⚠️ +4960
WiFi/examples/WiFiClientEvents⚠️ +2780⚠️ +4320⚠️ +4560⚠️ +4940⚠️ +5180⚠️ +4880
WiFi/examples/WiFiClientStaticIP⚠️ +2760⚠️ +4280⚠️ +4520⚠️ +4980⚠️ +5160⚠️ +4840
WiFi/examples/WiFiExtender⚠️ +2800⚠️ +4400⚠️ +4520⚠️ +4960⚠️ +5180⚠️ +4920
WiFi/examples/WiFiIPv6⚠️ +2820⚠️ +4360⚠️ +4200⚠️ +4940⚠️ +5160⚠️ +4960
WiFi/examples/WiFiMulti⚠️ +2740⚠️ +4120⚠️ +4480⚠️ +4940⚠️ +5160⚠️ +4920
WiFi/examples/WiFiMultiAdvanced⚠️ +2760⚠️ +4320⚠️ +4320⚠️ +4960⚠️ +5180⚠️ +4800
WiFi/examples/WiFiScan⚠️ +2780⚠️ +4240⚠️ +4320⚠️ +4980⚠️ +5200⚠️ +4880
WiFi/examples/WiFiScanAsync⚠️ +2780⚠️ +4280⚠️ +4480⚠️ +4940⚠️ +5180⚠️ +4920
WiFi/examples/WiFiScanDualAntenna⚠️ +2760⚠️ +4400⚠️ +4640⚠️ +4940⚠️ +5180⚠️ +4840
WiFi/examples/WiFiScanTime⚠️ +2740⚠️ +4240⚠️ +4560⚠️ +4940⚠️ +5180⚠️ +4880
WiFi/examples/WiFiTelnetToSerial⚠️ +2780⚠️ +4400⚠️ +4480⚠️ +4960⚠️ +5180⚠️ +4840
WiFi/examples/WiFiUDPClient⚠️ +2820⚠️ +4280⚠️ +4520⚠️ +4940⚠️ +5160⚠️ +4800
WiFi/examples/WPS--⚠️ +4240⚠️ +4600⚠️ +4940⚠️ +5180⚠️ +4880
WiFi/examples/WiFiBlueToothSwitch--⚠️ +4320--⚠️ +4940⚠️ +5200⚠️ +5040
WiFi/examples/WiFiClientEnterprise--⚠️ +4360⚠️ +4600⚠️ +4960⚠️ +5180⚠️ +4880
WiFi/examples/WiFiSmartConfig--⚠️ +4400⚠️ +4560⚠️ +4940⚠️ +5200⚠️ +4840

SuGlider
SuGlider approved these changes Mar 10, 2025
View reviewed changes
Copy link
Collaborator

@SuGlider SuGlider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuGlider SuGlider added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Mar 10, 2025
@SuGlider SuGlider added this to the 3.2.0 milestone Mar 10, 2025
@me-no-dev me-no-dev merged commit eeb6a26 into master Mar 10, 2025
56 checks passed
@me-no-dev me-no-dev deleted the bugfix/wifi_lr_disable branch March 10, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuGlider SuGlider SuGlider approved these changes

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

Assignees
No one assigned
Labels
Area: WiFi Issue related to WiFi Status: Pending Merge Pull Request is ready to be merged
Projects
Arduino ESP32 Core Project Roadmap
Status: Done
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@me-no-dev @SuGlider @P-R-O-C-H-Y