Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(matter): removes a few matter 1.4 / IDF 5.4 compilation warning messages #11067

Merged
merged 2 commits into from
Mar 10, 2025

Conversation

SuGlider
Copy link
Collaborator

Description of Change

A Maintainance PR to remove a few compilation warning messages:

libraries\Matter\src/MatterEndpoints/MatterEnhancedColorLight.h:94:30: warning: missing initializer for member 'HsvColor_t::s' [-Wmissing-field-initializers]
libraries\Matter\src/MatterEndpoints/MatterEnhancedColorLight.h:94:30: warning: missing initializer for member 'HsvColor_t::v' [-Wmissing-field-initializers]
libraries\Matter\src/MatterEndpoints/MatterColorLight.h:70:30: warning: missing initializer for member 'HsvColor_t::s' [-Wmissing-field-initializers]
libraries\Matter\src/MatterEndpoints/MatterColorLight.h:70:30: warning: missing initializer for member 'HsvColor_t::v' [-Wmissing-field-initializers]

Tests scenarios

CI only

Related links

None

@SuGlider SuGlider added the Area: Matter Issues and Feature Request about Matter Protocol label Mar 10, 2025
@SuGlider SuGlider added this to the 3.2.0 milestone Mar 10, 2025
@SuGlider SuGlider self-assigned this Mar 10, 2025
Copy link
Contributor

github-actions bot commented Mar 10, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello SuGlider, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 762966b

Copy link
Contributor

github-actions bot commented Mar 10, 2025

Test Results

 76 files   76 suites   12m 45s ⏱️
 38 tests  38 ✅ 0 💤 0 ❌
241 runs  241 ✅ 0 💤 0 ❌

Results for commit 762966b.

♻️ This comment has been updated with latest results.

Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32S3000.000.00000.000.00
ESP32S2000.000.00000.000.00
ESP32C3000.000.00000.000.00
ESP32C6000.000.00000.000.00
ESP32000.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32S3ESP32S2ESP32C3ESP32C6ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
Matter/examples/MatterColorLight0000000000
Matter/examples/MatterCommissionTest0000000000
Matter/examples/MatterComposedLights0000000000
Matter/examples/MatterContactSensor0000000000
Matter/examples/MatterDimmableLight0000000000
Matter/examples/MatterEnhancedColorLight0000000000
Matter/examples/MatterFan0000000000
Matter/examples/MatterHumiditySensor0000000000
Matter/examples/MatterMinimum0000000000
Matter/examples/MatterOccupancySensor0000000000
Matter/examples/MatterOnIdentify0000000000
Matter/examples/MatterOnOffLight0000000000
Matter/examples/MatterOnOffPlugin0000000000
Matter/examples/MatterPressureSensor0000000000
Matter/examples/MatterSmartButon0000000000
Matter/examples/MatterTemperatureLight0000000000
Matter/examples/MatterTemperatureSensor0000000000
Matter/examples/MatterThermostat0000000000
Matter/examples/WiFiProvWithinMatter0000000000

@SuGlider SuGlider added the Status: Review needed Issue or PR is awaiting review label Mar 10, 2025
@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Mar 10, 2025
@me-no-dev me-no-dev merged commit e680e7b into master Mar 10, 2025
87 of 93 checks passed
@me-no-dev me-no-dev deleted the fix/matter_1.4 branch March 10, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Matter Issues and Feature Request about Matter Protocol Status: Pending Merge Pull Request is ready to be merged
Projects
Development

Successfully merging this pull request may close these issues.

4 participants