Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(matter): examples must set pin to Digital Mode after analogWrite() and before digitalWrite() #11070

Merged
merged 8 commits into from
Mar 10, 2025

Conversation

SuGlider
Copy link
Collaborator

Description of Change

When no RGB LED is used, a regular LED is used, in the examples, to demonstrate Light Brightness or the Fan Motor Power.

The regular LED is driven with analogWrite() and set OFF with digitalWrite(pin, LOW). In order to set it OFF, it is necessary to set the pin to Digital Mode OUTPUT, otherwise an error will be displayed in the UART console.

Tests scenarios

Using ESP32.

None

@SuGlider SuGlider self-assigned this Mar 10, 2025
@SuGlider SuGlider added Status: Review needed Issue or PR is awaiting review Area: Matter Issues and Feature Request about Matter Protocol labels Mar 10, 2025
@SuGlider SuGlider added this to the 3.2.0 milestone Mar 10, 2025
Copy link
Contributor

github-actions bot commented Mar 10, 2025

Warnings
⚠️

The source branch "fix/matter_examples_digitalWrite" incorrect format:

  • contains uppercase letters. This can cause troubles on case-insensitive file systems (macOS).
    Please rename your branch.

👋 Hello SuGlider, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 9401cf9

@SuGlider
Copy link
Collaborator Author

Wow, @P-R-O-C-H-Y, --- That was really FAST!!!! 🥇

@SuGlider SuGlider requested a review from me-no-dev March 10, 2025 19:34
Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32S30⚠️ +4800.00⚠️ +0.03000.000.00
ESP32S20⚠️ +4840.00⚠️ +0.03000.000.00
ESP32C30⚠️ +5140.00⚠️ +0.03000.000.00
ESP32C60⚠️ +5380.00⚠️ +0.03000.000.00
ESP320⚠️ +5360.00⚠️ +0.03000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32S3ESP32S2ESP32C3ESP32C6ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
Matter/examples/MatterColorLight⚠️ +4440⚠️ +4560⚠️ +5100⚠️ +5320⚠️ +5200
Matter/examples/MatterDimmableLight⚠️ +4800⚠️ +4840⚠️ +5100⚠️ +5320⚠️ +5080
Matter/examples/MatterEnhancedColorLight⚠️ +4600⚠️ +4760⚠️ +5140⚠️ +5380⚠️ +5160
Matter/examples/MatterFan⚠️ +4760⚠️ +4800⚠️ +5120⚠️ +5340⚠️ +5360
Matter/examples/MatterTemperatureLight⚠️ +4640⚠️ +4840⚠️ +5120⚠️ +5340⚠️ +4800

@me-no-dev me-no-dev added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Mar 10, 2025
@me-no-dev me-no-dev merged commit d9dbc4a into master Mar 10, 2025
25 checks passed
@me-no-dev me-no-dev deleted the fix/matter_examples_digitalWrite branch March 10, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Matter Issues and Feature Request about Matter Protocol Status: Pending Merge Pull Request is ready to be merged
Projects
Development

Successfully merging this pull request may close these issues.

3 participants