-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(matter): examples must set pin to Digital Mode after analogWrite() and before digitalWrite() #11070
Conversation
👋 Hello SuGlider, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Wow, @P-R-O-C-H-Y, --- That was really FAST!!!! 🥇 |
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
Description of Change
When no RGB LED is used, a regular LED is used, in the examples, to demonstrate Light Brightness or the Fan Motor Power.
The regular LED is driven with
analogWrite()
and set OFF withdigitalWrite(pin, LOW)
. In order to set it OFF, it is necessary to set the pin to Digital Mode OUTPUT, otherwise an error will be displayed in the UART console.Tests scenarios
Using ESP32.
None