Update AsyncUDP library.json #2837
Conversation
|
ping @me-no-dev does this make sense for you? |
libraries/AsyncUDP/library.json
Outdated
| } | ||
| "frameworks": [ | ||
| "arduino" | ||
| ], |
There was a problem hiding this comment.
changing frameworks to a list is not necessary
|
Happy to make the requested changes. As for the platform I was under the impression that this repo is for esp32 only and esp8266 i supported at https://github.com/me-no-dev/ESPAsyncUDP.git? Are you actually suggesting that I should open this PR upstream? |
|
You are correct that this is only for the esp32, I missed which repo this was on and removed that comment after checking further. This version should only be for espressif32. |
|
Looking at the other embedded libraries- should we maybe drop the library.json altogether? |
|
That is an option but it would need to be tested and confirm that PIO won't complain about it being missing. |
Just verified that my PIO project compiles without it present. No other included library does have this file either ;) |
|
Then I'd suggest drop it from here :) |
|
Pr is already updated- up to you :) |
|
Hey @andig :) Long time no see :D |
So true- hope you're doing well! |
Fix #2836 and platformio/platform-espressif32#186