Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/http client #2867

Merged
merged 8 commits into from
Aug 20, 2019
Merged

Bugfix/http client #2867

merged 8 commits into from
Aug 20, 2019

Conversation

Jeroen88
Copy link
Contributor

@Jeroen88 Jeroen88 commented Jun 6, 2019

Made a mistake in parsing the header for HTTP1.0 in #6152. This PR corrects this.

@Jeroen88
Copy link
Contributor Author

Jeroen88 commented Jun 6, 2019

Updated the reuse logic to be in line with the ESP8266.

… in connect() in case _client was set null
@Jeroen88
Copy link
Contributor Author

Jeroen88 commented Jul 6, 2019

Do not merge this PR yet. It has an unsolved problem that I am tracking on the same PR for the ESP8266

@me-no-dev
Copy link
Member

@Jeroen88 make sure you ping me on gitter once this is OK for merge :) I might miss it here

@Jeroen88
Copy link
Contributor Author

@me-no-dev Sure, I will :) However, I have the same PR for ESP8266 (see here), and I think there are still reuse issues. I think so by looking at the code. However, I miss the protocol knowledge to be sure, nor do I have defined test cases (send request header Connection: Keep-Alive, get response header Connection: Close, I think ::disconnect() should be called, and ::connect() on the next POST, but is that true?; Is it possible that a connection is reset during a Keep-Alive situation and should it be handled by HTTPClient?).
Could you please have a look at my last post at that PR and give your opinion? It is holiday time here, so I will have other priorities for the next few weeks :)

@Jeroen88
Copy link
Contributor Author

Jeroen88 commented Aug 6, 2019

@me-no-dev the HTTPClient library is in line with the ESP8266HTTPClient library, as far as reusing the connection is concerned. I tested the changes on the ESP8266. Also I ran the ESP32 code to test HTTP/1.0 and HTTP/1.1, both with ::setReuse(false) and ::setReuse(true). Everything seems to be fine now...

@me-no-dev me-no-dev merged commit f4acac4 into espressif:master Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants