Reduce flash usage up to 214k in one click #2929
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gets rid of stringstream and exception usage in @nkolban BLE library. While stringstream itself is a good and safe thing on mature desktop platforms, using it in embedded world mostly for debugging purposes has its impact. In this case we can save about 214k.
Here's a metrics of my test image build.
Note: by default exceptions seems to be enabled in Arduino build configuration. So, actual flash size benefit from this PR on most platforms can be about 137k.