Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update boards.txt #2933

Merged
merged 3 commits into from
Jul 10, 2019
Merged

Update boards.txt #2933

merged 3 commits into from
Jul 10, 2019

Conversation

atanisoft
Copy link
Collaborator

Adding ESP32-WROOM-32 8MB flash option
See #2931

Adding ESP32-WROOM-32 8MB flash option
Copy link

@Triangulix Triangulix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second added line should also state "8M". Thanks again.

@atanisoft
Copy link
Collaborator Author

Yup, you are right. Let me fix.

Fixing partition size and typo
boards.txt Outdated
@@ -104,6 +106,9 @@ esp32.menu.FlashFreq.40.build.flash_freq=40m

esp32.menu.FlashSize.4M=4MB (32Mb)
esp32.menu.FlashSize.4M.build.flash_size=4MB
esp32.menu.FlashSize.8M=8MB (64Mb)
esp32.menu.FlashSize.8M.build.flash_size=8MB
esp32.menu.FlashSize.2M.build.partitions=default_8MB
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2M should be 8M in this line

@me-no-dev me-no-dev merged commit 7dbda49 into espressif:master Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants