ESP8266 => ESP32 tidyup, set correct default port #2948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tidied up references to the ESP8266, and set the correct default port for the ESP32.
pfeerick
referenced
this pull request
in platformio/platform-espressif32
Jul 1, 2019
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tidied up references to the ESP8266, and set the correct default port for the ESP32.
The latter point is the main reason for this PR - I discovered that when you run the
espota.pytool from this repo against a ESP32 without overriding the default port it would not work... but it was being overridden when run via the Arduino IDE.I'm hoping this is just leftovers, and can be corrected?