WPA2 connection fix (significant improvement to connection time) #2989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice find! Let's merge this and see how it goes :) |
OttoWinter
added a commit
to esphome/esphome
that referenced
this pull request
Oct 18, 2019
OttoWinter
added a commit
to esphome/esphome
that referenced
this pull request
Oct 18, 2019
* Enable MDNS logs comment * Work around ESP8266 mDNS broken for AP See also esp8266/Arduino#6114 * Enable captive_portal in AP-only mode Fixes esphome/issues#671 * Make ESP32 connecting faster See also espressif/arduino-esp32#2989 * Format
OttoWinter
added a commit
to esphome/esphome
that referenced
this pull request
Nov 12, 2019
3 tasks
silverchris
pushed a commit
to silverchris/esphome
that referenced
this pull request
May 23, 2020
* Enable MDNS logs comment * Work around ESP8266 mDNS broken for AP See also esp8266/Arduino#6114 * Enable captive_portal in AP-only mode Fixes esphome/issues#671 * Make ESP32 connecting faster See also espressif/arduino-esp32#2989 * Format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to finally fix/workaround the bug that has been plaguing WPA2 connections.
In my testing (home network, WPA2 Personal), connection time has improved from ~1200ms to ~300-350ms.
The issue seems to be that the underlying WiFi API needs esp_wifi_set_config() to be explicitly called. Perhaps some lwIP settings aren't applied. It might even be a clash with the ARP check config specifically.
This is not specific to Arduino, but it is a band-aid for now. Also tested with esp-idf (PlatformIO) , esp-idf + Arduino component (PlatformIO), Arduino (IDE and PlatformIO).
I'll create an issue on the esp-idf repo soon.
Hopefully helps with #1675, #2798, etc