Permit notify
event subscription when BLE servers don't require registration
#4659
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
I have an iTag that I'm wanting to use as a BLE button to control an application on my ESP32.
Problem
The iTag doesn't require explicit registration for a client to be able to listen to
notify
events. Currently, theBLERemoteCharacteristic::registerForNotify
function tries to update the remote descriptor at0x2902
and register/unregister the client as required.As the iTag doesn't have this descriptor, it causes an unhandled exception error and crashes the application.
Changes
To support devices that don't require you to explicitly register to follow such events, I've added a simple
descriptorRequiresRegistration
flag to theBLERemoteCharacteristic::registerForNotify
function. This defaults to true, for backward compatibility.Thanks!