Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor BLEAdvertisedDevice #4739

Merged
merged 2 commits into from
Feb 16, 2021
Merged

Refactor BLEAdvertisedDevice #4739

merged 2 commits into from
Feb 16, 2021

Conversation

mkfrey
Copy link
Contributor

@mkfrey mkfrey commented Jan 22, 2021

  • Prevent possible undefined behaviour by get methods not taking an index as parameter
  • Add methods to get the count of service data UUIDs and service UUIDs
  • Various code improvements

@mkfrey
Refactor BLEAdvertisedDevice
4d2600d 
* Prevent possible undefined behaviour by get methods not taking an index as parameter
* Add methods to get the count of service data UUIDs and service UUIDs
* Various code improvements
@mkfrey
Copy link
Contributor Author

mkfrey commented Jan 25, 2021

Will also fix #4596.

@me-no-dev me-no-dev merged commit 7cdfb8b into espressif:master Feb 16, 2021
@me-no-dev
Copy link
Member

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkfrey @me-no-dev