Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tools/sdk/include/nimble from include path #4891

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

maxgerhardt
Copy link
Contributor

@maxgerhardt maxgerhardt commented Mar 4, 2021

For the PlatformIO build script.

Per https://github.com/espressif/arduino-esp32/tree/master/tools/sdk/include this folder doesn't exist exist anymore, so users will see a warning in VSCode regarding this non-existent folder (see here for example).

I don't know whether nimble has been removed or renamed, but this change just removes the reference to the folder in the platformio build script.

It looks like it's also gone from other branches (v4.0, v4.2), so.. it should also be merged there I guess.

@me-no-dev
Copy link
Member

this is done automatically. will accept the PR now and fix it in the builder

@me-no-dev me-no-dev merged commit 0e0a756 into espressif:master Mar 4, 2021
@maxgerhardt
Copy link
Contributor Author

Thanks - I see the commit at espressif/esp32-arduino-lib-builder@45370ab

Just to reiterate: It is correct that arduino-esp32 doesn't contain the nimble include folder anymore? If the builder script iterates through all built components that end up in Arduino-ESP32, it's kinda weird how there's only exception.

@me-no-dev
Copy link
Member

that is an old script to work with the make build system for IDF. The 4.2 branch uses a different approach that actually extracts the build parameters from the cmake system itself. Nimble should not be there because it's not built with Arduino (bluedroid is)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants