-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add KSZ8081 support. #5061
Add KSZ8081 support. #5061
Conversation
This adds support for the KSZ8081 ethernet phy. Only the IDF 4+ specific code is modified, as the phy support was only added recently: espressif/esp-idf@aecfbf96
Thanks :) |
I'm pretty sure this broke build against @rtrbt any recommendations? Edit: I figured it out. |
Yea this PR broke esp-idf 4.3 that platformio uses |
Building with pio works if you use the idf-master branch of the platform package like this: I could also add a version check to the ksz8081 specific code, so it is only compiled in if ESP-IDF 4.4 is available. But I'm not sure if this is a good idea, because a quick grep did not find any usage of IDF_MINOR or ESP_IDF_VERSION_MINOR (assuming this isn't the only occurence of code that does require a higher version than 4.0). @me-no-dev: Any thoughts? |
Sounds to me like this is more of a platformio issue then. I was just mentioning it as a comment in case anyone else got stuck with the build errors and wanted some information on why the error was occuring if using platformio. |
This PR also broke VSCode official plug-in and idf.py... if you go IDF official github, you can see that the function Lets hope that 4.4 fix this in the mean time commenting out this PR modification does the trick, hopefully should be harmless unless you want to use the ksz8081 IC for Ethernet (which is not supported on 4.3 anyway).... |
FYI: #5599 |
Cool anyway version 3.4.1 was just released with the function esp_eth_phy_new_ksz8081 in place |
This adds support for the KSZ8081 ethernet phy.
Only the IDF 4+ specific code is modified, as the phy support was only
added recently:
espressif/esp-idf@aecfbf96