Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add uPesy ESP32 DevKit boards support #5144

Merged
merged 4 commits into from
Jun 9, 2021
Merged

Add uPesy ESP32 DevKit boards support #5144

merged 4 commits into from
Jun 9, 2021

Conversation

uPesy
Copy link
Contributor

@uPesy uPesy commented May 2, 2021

Please add uPesy ESP32 DevKit boards support

@CLAassistant
Copy link

CLAassistant commented May 2, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@valeros valeros mentioned this pull request May 10, 2021
Open
@me-no-dev
Copy link
Member

I think both boards can use the same variant, no?

uPesy
uPesy commented May 18, 2021
View reviewed changes
Copy link
Contributor Author

@uPesy uPesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it's the same pins_arduino.h file for both uPesy ESP32 Wroom DevKit board and uPesy ESP32 Wrover DevKit board.

@me-no-dev me-no-dev merged commit fb513c7 into espressif:master Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uPesy @CLAassistant @me-no-dev