add onMtuChanged to BLEServerCallbacks #5222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add method onMtuChanged to the BLEServerCallbacks so the application can be notified if the MTU size changes.
|
|
Correct missing semicolon and misspelled method.
chegewara
approved these changes
May 31, 2021
libraries/BLE/src/BLEServer.h
Outdated
| * @param [in] pServer A reference to the %BLE server that received the client connection. | ||
| * @param [in] param A reference to esp_ble_gatts_cb_param_t. | ||
| */ | ||
| virtual void onMtuChanged(BLEServer* pServer, esp_ble_gatts_cb_param_t* param) |
There was a problem hiding this comment.
Something is missing here ;.
There was a problem hiding this comment.
Yeah I saw that. I corrected the code and committed it to my fork. Let me know if I need to do anything more.
There was a problem hiding this comment.
Odd, i commented this 2 days ago.
There was a problem hiding this comment.
Hmmm, just got an email this morning of the failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add method onMtuChanged to the BLEServerCallbacks so the application can be notified if the MTU size changes.