[WiFiClient] Default connection timeout, when no timeout provided #5487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks @cziter15 ! |
|
You're welcome :) My project heavily bases on esp-arduino, visit in the meantime: That's why I'm digging in esp32 Arduino core too. |
|
Use WiFiClient connecting to server always failed until set timeout to 3s |
me-no-dev
pushed a commit
that referenced
this pull request
Aug 11, 2021
## Summary #5487 introduced a default timeout for WiFiClient, however the default was specified in milliseconds instead of seconds, see be84c82#commitcomment-54358731 This 3ms timeout breaks OTA when the processor is busy. ## Impact Sets the default to a saner value, fixes OTA.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
WiFiClient's connect method variant where no timeout is passed can block esp32 MCU and may then cause watchdog to kick in and reset the device. This behavior is different from that, what is in arduino-esp8266 core.
Summary
Some cross-esp libraries (working both on esp32 and 8266), like PubSubClient simply call connect method on WiFiClient, to get connected to remote server. However, connect behavior varies betwen esp arduino 8266 and esp arduino 32 cores. This pull request tries introduce same behavior - to make connect method non-blocking on esp32, like it is with 8266 arduino core.
Proposed solution
Introduce default fixed timeout that can be changed by #define - by default set to 3 seconds.
Affected components:
WiFiClient
Affected methods:
Impact
May impact projects or libraries using connect method variant without specified timeout, where: