Add string constructor and concat routines taking explicit length args #5586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From upstream ArduinoCore-API commit 3b88acac8ee00fc57bc3328e68823aa53088f891
From upstream ArduinoCore-API commit 84314888a8a73b643469c5609beed6d21d1c037a
|
|
From upstream ArduinoCore-API commit dd236bfd2c62ed083aaa1b1229d71e85fd92f7a9
From upstream ArduinoCore-API commit eaab14db09073afc20bcf26bd9b7448a6a1309b0
From upstream ArduinoCore-API commit 0d83f1afc3367037dbde5323c2abd0ae1bd2c583
rcombs
force-pushed
the
string-explicit-length
branch
from
c11e99d to
2000160
Compare
|
thanks @rcombs :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Applies the upstream changes here: arduino/ArduinoCore-API@3b88acac8^...0d83f1a
Impact
Adds new String convenience methods that are now available in the mainline Arduino implementation, simplifying interoperability with C code that uses pointer+length strings rather than 0-termination. Also includes a change to avoid mutating the source string when taking a substring.