Append '/' to an URL with empty path in HTTPClient::begin #5634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
atanisoft
reviewed
Sep 8, 2021
| @@ -261,6 +261,10 @@ bool HTTPClient::beginInternal(String url, const char* expectedProtocol) | |||
| url.remove(0, (index + 3)); // remove http:// or https:// | |||
|
|
|||
| index = url.indexOf('/'); | |||
| if (index == -1) { | |||
| log_e("the path of url must not be empty"); | |||
| return false; | |||
There was a problem hiding this comment.
I agree a check is needed here to prevent using -1 for index, but I don't think it should be an error. If you type in "example.com" into a browser it defaults the path to / for you. Likely this code should do the same in this case. Perhaps something like this inside this new condition block:
url += '/';
index = url.indexOf('/');
It will incur the cost of calling indexOf a second time but I don't think there are many options around this.
There was a problem hiding this comment.
I think so too. I'll fix this.
I don't think there are many options around this.
The method length can be also used.
long-long-float
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Append '/' to an URL with empty path in HTTPClient::begin. For example,
http.begin("http://example.com")is the same ashttp.begin("http://example.com/").Add an error check for empty path of HTTPClient::begin. For example,http.begin("http://example.com")returns false because the path of it is empty (http.begin("http://example.com/")returns true).RFC2616 and RFC2396 say this url is invalid. Furthermore, most servers return
400 Bad Request.