Fixes boards.txt entries for the atmegazero_esp32s2, and also the pla… #5673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tform.txt --flash_size which is not letting the board compile due to its 32MB size.
This was referenced Sep 15, 2021
|
LGTM. @pedrominatel, please, merge this. I will refactor my #5623 to fix the deneyapmini board only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the compiling issue with the ATMegaZero ESP32-S2 board. I had entered some values wrong in the boards.txt definition for this board but I fixed them in this PR.
I'm also having issues compiling because of the
-flash-size detectflag which is not respecting the flash-size entered in the boards.txt file and instead is auto-detecting the size of memory on the board. This will fail on the ATMegaZero since this board comes with 32MB of Flash memory but at the moment we are only using 16MB due to esptool.py limitations.Impact
It will fix the atmegazero_esp32s2 board, which is affecting a lot of our users who want to use Arduino vs CircuitPython.