libraries/SPI/src/SPI.h: SPIClass: add method to get SS pin number #5788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As code example states, the SS pin needs to be explicitly set for output for SPI to work, but the pin number have to be coded in addition to the SPI logic in the library, which means this duplicates code. It is much better to just be able to get the pin number from library itself.
Simplify the example case, to show usage of pinSS method. This also simplifies the example, removing duplicated code.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds new method to SPIClass, so the user can get, which pin is the SS signal. This makes use of the class easier, if one needs to toggle the SS pin. This is demonstrated by simplification of the example, which is using multiple SPI buses and had to have the SS pin numbers hardcoded, outside of the logic of the SPI class and also there was some code duplication, which is now removed, due to this new function.
Since this PR extends the interface, the change is backwards compatible, but will benefit any future users.