[Examples] WiFi and Ethernet examples organization #5830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL @me-no-dev and evaluate the risks and pros and cons of this change. |
|
There are no risks other than maybe breaking some links somewhere on the web. |
Rotzbua
suggested changes
Nov 2, 2021
libraries/WiFi/library.properties
Outdated
| @@ -1,4 +1,4 @@ | |||
| name=WiFi | |||
| name=WiFi and Ethernet | |||
There was a problem hiding this comment.
This breaks dependencies, do not change the name.
|
@pedrominatel why not also move ETH.h and ETH.cpp into the new lib? (you would need to adjust CMakeLists.txt as well) |
|
PTAL @me-no-dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is to change the WiFi and Ethernet examples organization in a separated folder. Two folders were created for WiFi and Ethernet examples.
Impact
WiFi examples now are in a different folder location. This may cause some impacts on external references to the examples.