-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix I2C Slave Compile #6108
Fix I2C Slave Compile #6108
Conversation
I2C Slave currently doesn't compile for projects where Arduino is an IDF component. This adds missing conditionals.
@Jason2866 That fix is in "esp32-hal-spi.c" and appears unrelated to my fix in "esp32-hal-i2c-slave.c". |
I thought you want to fix all issues when Arduino is used as IDF component. |
@Jason2866 Gotcha. I just found the repository "tasmota / arduino-esp32". Impressive work! |
The real impressive (why it is made) is the project which use -> https://github.com/arendst/Tasmota |
@me-no-dev It appears the automated checks failed because of a network timeout. |
merged :) |
Summary
I2C Slave currently doesn't compile for projects where Arduino is an IDF component. This adds missing conditionals.
Impact
esp32-hal-i2c-slave.c will compile
Related links
N/A