Fix Check for _cookieJar in HTTPClient (#6266)

[bbsan2k]

This entire section above can be deleted if all items are checked.

---

Summary

Fix nullptr in HTTPClient with _cookieJar

Impact

Fixes #6266

[CLAassistant]

All committers have signed the CLA.

[mrengineer7777]

Question: does this code fix just indent the function and put brackets around it for "if (_cookieJar)"?
Suggestion: rather than indenting all the code, use this shorter form:
if (!_cookieJar) return; Note the "!", which is equivalent to if(_cookieJar==NULL).
Feel free to break it into two lines and/or add braces as fits the coding style.
e.g.

if (!_cookieJar) return;
if (!_cookieJar) { return; }
if (!_cookieJar) { return; }

This comment is not a review on the actual fix, just a way to minimize changes and make it easier to review.
Edit: Github does not display the CR for the inline code.

[bbsan2k]

Question: does this code fix just indent the function and put brackets around it for "if (_cookieJar)"? Suggestion: rather than indenting all the code, use this shorter form: if (!_cookieJar) return; Note the "!", which is equivalent to if(_cookieJar==NULL). Feel free to break it into two lines and/or add braces as fits the coding style. e.g.

if (!_cookieJar) return; if (!_cookieJar) { return; } if (!_cookieJar) { return; }

This comment is not a review on the actual fix, just a way to minimize changes and make it easier to review. Edit: Github does not display the CR for the inline code.

I wanted to avoid having multiple return paths for the code for better maintainability / debugging. This way the code reaches the end of the functions' scope, no matter what.

But I also understand the approach to try to return as soon as possible. What is the general strategy and code style for this within arduino framework / component?

[me-no-dev]

I will agree with @mrengineer7777 here. Exit as soon as possible.

if (!_cookieJar) {
    return;
}

[bbsan2k]

Ok, PR is updated 😊