Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new "Non TinyUF2 bootloader only" capability for boards that support TinyUF2 bootloaders #6668

Merged
merged 1 commit into from
May 4, 2022

Conversation

UnexpectedMaker
Copy link
Contributor

@UnexpectedMaker UnexpectedMaker commented Apr 30, 2022

Description of Change

Implemented a new method for allowing folks to preserve their TinyUF2 bootloader setup when flashing their boards via Arduino IDE, without being locked out of not using it if they want to use a different partition.

Adafruit had already added support for keeping (reflashing) the TinyUF2 bootloader when flashing via Arduino IDE (thanks @ladyada ), but the issue with it is it doesn't allow users to not choose to use it. Even if they select a specific partition scheme from the partition drop down list, it ignores that selection and only does the TinyUF2 partitioning/bootloader thing.

We wanted to let users choose between keeping their TinyUF2 partitioning and bootloader, or choose another partition scheme and have the TinyUF2 support disabled and just operate like they would expect.

We've implemented this by adding the TinyUF2 support as a partition scheme option, and using these build options in platform.txt to choose to use teh UF2 path or use the standard path.

tinyuf2_support

Tests scenarios

This has been tested in 2.0.3RC1 and latest master on all UM ESP32-S3 boards, with and without TinyUF2 support, and also tested on the Adafruit QT PY to ensure it still retains the UF2 and on a TinyS2 with a standard 4MB partition, and all boards and options works correctly!

Related links

N/A

@CLAassistant
Copy link

CLAassistant commented Apr 30, 2022

CLA assistant check
All committers have signed the CLA.

@UnexpectedMaker UnexpectedMaker changed the title Added new "Non TinyUF2 bootloader only" capability for boards support TinyUF2 bootloaders Added new "Non TinyUF2 bootloader only" capability for boards that support TinyUF2 bootloaders Apr 30, 2022
@UnexpectedMaker
Copy link
Contributor Author

@me-no-dev I don't understand why CLA assistant is wanting me to sign by 2 identities when I only use the Unexpected Maker profile. I don't even know how to change to this other Seon Rozenblum profile :(

@UnexpectedMaker
Copy link
Contributor Author

@me-no-dev I don't understand why CLA assistant is wanting me to sign by 2 identities when I only use the Unexpected Maker profile. I don't even know how to change to this other Seon Rozenblum profile :(

Don't worry, @prplz helped me fix the commit and now it's on my signed user.

@VojtechBartoska
Copy link
Contributor

@me-no-dev I don't understand why CLA assistant is wanting me to sign by 2 identities when I only use the Unexpected Maker profile. I don't even know how to change to this other Seon Rozenblum profile :(

That's weird. I have no idea why this happened.

@UnexpectedMaker
Copy link
Contributor Author

UnexpectedMaker commented May 3, 2022

@me-no-dev I don't understand why CLA assistant is wanting me to sign by 2 identities when I only use the Unexpected Maker profile. I don't even know how to change to this other Seon Rozenblum profile :(

That's weird. I have no idea why this happened.

It was actually from my side. I sometimes use SmartGit and sometimes use command line, and my git credentials must have been messed in SmartGit, so it used my email instead of my GitHub login. It's all good now :)

@me-no-dev me-no-dev merged commit ba591fd into espressif:master May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants