-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Additional Adafruit boards including the new Qualia ESP32-S3 and Camera ESP32-S3 #8696
Conversation
Add MatrixPortal ESP32-S3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@makermelissa PTAL on my comments.
boards.txt
Outdated
|
||
# Adafruit Qualia ESP32-S3 RGB666 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing line of # to separate boards
# Adafruit Qualia ESP32-S3 RGB666 | |
############################################################## | |
# Adafruit Qualia ESP32-S3 RGB666 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you missed that one @ladyada ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm i see the change in the PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, they showed up now... maybe GH is a bit slow
@ladyada @makermelissa Can you please take a look on my comments quickly? We are preparing 2.0.14 release right now. Thanks |
lookin! |
Co-authored-by: Jan Procházka <[email protected]>
Co-authored-by: Jan Procházka <[email protected]>
ok i believe all were done. if i can have another 10 minutes i have another silly fix i have to make (i used OPI PSRAM pins on a board and turns out you cant do that :D ) |
@ladyada you can have another 10 😆 |
(doing last hardware tests...) |
ok done, for real! srsly! no backies |
You still got time till the CI is done ;) |
nah i think we're good now, lots of fun hardware and now it even works right ;) |
@me-no-dev woops this actually got reverted in a '5.1' update script ill resubmit a new PR! |
Description of Change
Adds Additional Adafruit boards including the new Qualia ESP32-S3 and Camera ESP32-S3
Tests scenarios
Please describe on what Hardware and Software combinations you have tested this Pull Request and how.
(eg. I have tested my Pull Request on Arduino-esp32 core v2.0.2 with ESP32 and ESP32-S2 Board with this scenario)
Related links
Please provide links to related issue, PRs etc.
(eg. Closes #number of issue)