Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partial type match is sufficient (RDT-588) #11

Closed
defermelowie opened this issue Nov 16, 2023 · 2 comments · Fixed by #15
Closed

Partial type match is sufficient (RDT-588) #11

defermelowie opened this issue Nov 16, 2023 · 2 comments · Fixed by #15
Assignees
@kumekay
Labels
Status: Done Issue is done internally Type: Bug Bug in conventional-precommit-linter

Comments

@defermelowie
Copy link

I noticed that a partial match of a type is sufficient to pass the check. For example git commit -m "rever: some commit msg" passes when using the configuration below.

...
- repo: https://github.com/espressif/conventional-precommit-linter
  rev: v1.3.0
  hooks:
    - id: conventional-precommit-linter
      stages: [commit-msg]
      args:
        - --types=feat,fix,ci,refactor,revert,merge
...

Is this intended behavior (to allow for abbreviations)? If so it might be useful to state this in the readme since I, and pehaps others, did not expect this.
@github-actions github-actions bot changed the title Partial type matched is allowed Partial type matched is allowed (RDT-588) Nov 16, 2023
@defermelowie defermelowie changed the title Partial type matched is allowed (RDT-588) Partial type match is sufficient (RDT-588) Nov 16, 2023
@tomassebestik
Copy link
Member

Hi @defermelowie ... no, this looks like a bug (match should be exact).
Thank you for spotting it... we'll fix it soon.

@tomassebestik tomassebestik self-assigned this Nov 30, 2023
@tomassebestik tomassebestik added Type: Bug Bug in conventional-precommit-linter Status: Selected for Development Issue is selected for development labels Nov 30, 2023
kumekay added a commit that referenced this issue Dec 4, 2023
@kumekay
fix: fix partial type matching
09cab3c 
Closes #11
@kumekay kumekay mentioned this issue Dec 4, 2023
Merged
kumekay added a commit that referenced this issue Dec 4, 2023
@kumekay
fix: fix partial type matching
235b908 
Closes #11
kumekay added a commit that referenced this issue Dec 4, 2023
@kumekay
fix: fix partial type matching
083926b 
Closes #11
@kumekay kumekay added Status: Reviewing Issue is being reviewed and removed Status: Selected for Development Issue is selected for development labels Dec 4, 2023
kumekay added a commit that referenced this issue Dec 5, 2023
@kumekay
fix: fix partial type matching
2c57914 
Closes #11
kumekay added a commit that referenced this issue Dec 5, 2023
@kumekay
fix: fix partial type matching
9f9c33b 
Closes #11
tomassebestik pushed a commit that referenced this issue Dec 9, 2023
@kumekay @tomassebestik
fix: fix partial type matching
39a7ad0 
Closes #11
@tomassebestik tomassebestik added Status: Done Issue is done internally and removed Status: Reviewing Issue is being reviewed labels Dec 9, 2023
@tomassebestik
Copy link
Member

tomassebestik commented Dec 9, 2023 •
edited
Loading

Hi @defermelowie,
this should be fixed now:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kumekay kumekay

Labels
Status: Done Issue is done internally Type: Bug Bug in conventional-precommit-linter
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix partial match of the commit type espressif/conventional-precommit-linter
3 participants
@kumekay @defermelowie @tomassebestik