Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Add an optional parameter to allow uppercase letters in the optional-scope (RDT-793) #25

Closed
ustccw opened this issue May 28, 2024 · 2 comments · Fixed by #26
Closed

Feature Request: Add an optional parameter to allow uppercase letters in the optional-scope (RDT-793) #25

ustccw opened this issue May 28, 2024 · 2 comments · Fixed by #26
Assignees
@petermESP
Labels
Status: Reviewing Issue is being reviewed

Comments

@ustccw
Copy link

ustccw commented May 28, 2024

@tomassebestik Hello!
The default conventional-precommit-linter will report the FAIL if <optional-scope> has uppercase letters.

FAIL: (optional-scope) if used, must be written in lower case without whitespace

Could we add an optional parameter (something like --ignore-case-scope) to allow uppercase letters in the <optional-scope>.
Thanks.
@github-actions github-actions bot changed the title Feature Request: Add an optional parameter to allow uppercase letters in the optional-scope Feature Request: Add an optional parameter to allow uppercase letters in the optional-scope (RDT-793) May 28, 2024
@tomassebestik tomassebestik self-assigned this May 28, 2024
@tomassebestik tomassebestik added the Status: Selected for Development Issue is selected for development label May 28, 2024
@petermESP petermESP mentioned this issue Jun 12, 2024
Merged
@tomassebestik tomassebestik added Status: Reviewing Issue is being reviewed and removed Status: Selected for Development Issue is selected for development labels Jun 13, 2024
petermESP added a commit that referenced this issue Jun 13, 2024
@petermESP
feat: Add '--scope-case-insensitive' optional argument
c85cf46 
Closes #25
tomassebestik pushed a commit that referenced this issue Jun 13, 2024
@petermESP @tomassebestik
feat: Add '--scope-case-insensitive' optional argument
c0a32fa 
Closes #25
@tomassebestik
Copy link
Member

@ustccw Feature available in release v1.9.0 (update your .pre-commit-config.yaml)

@ustccw
Copy link
Author

ustccw commented Jun 14, 2024

@tomassebestik thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermESP petermESP

Labels
Status: Reviewing Issue is being reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Added "--scope-case-insensitive" optional argument espressif/conventional-precommit-linter
3 participants
@ustccw @tomassebestik @petermESP