Symbolic block number is now allowed in library mode #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making progress Updating readme Fixing up tests Update changelog
There was a problem hiding this comment.
Copilot reviewed 2 out of 12 changed files in this pull request and generated 1 comment.
Files not reviewed (10)
- cli/cli.hs: Language not supported
- src/EVM.hs: Language not supported
- src/EVM/Exec.hs: Language not supported
- src/EVM/Fetch.hs: Language not supported
- src/EVM/SymExec.hs: Language not supported
- src/EVM/Types.hs: Language not supported
- src/EVM/UnitTest.hs: Language not supported
- test/EVM/Test/BlockchainTests.hs: Language not supported
- test/EVM/Test/Tracing.hs: Language not supported
- test/rpc.hs: Language not supported
blishko
approved these changes
Apr 8, 2025
|
My review is not much better than Copilot's 😅 |
|
Hahah, no, I think yours is actually helpful, indicates I need to do better. So I decided to add a test case, thanks to @gustavo-grieco who contributed it. Let me add it and then merge :) |
|
Haha, the test case highlighted I forgot to change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change only affects library mode. In this mode, we now allow the block number to be symbolic. This is helpful for Echidna. It's a very minor change, and should not affect any use-case beyond being used as a library.
Built on top of #691 . Needs #691 to be merged before it makes any sense.
Checklist