-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump websocksets to 15+ #3653
Conversation
04da047
to
9073cb1
Compare
Thanks @0xRAG. We've discussed this and I think for the purposes of not breaking, we should keep python 3.8 support and remain on a I realized that all breaking changes happen under the I am going to cherry-pick some of those commits here if you don't mind and we can take a last look together and see if this checks all the boxes. cc: any and all in #3641 |
Sounds good thanks @fselmo! |
Looks like @0xRAG does this work as a first step toward compatibility with no breaking changes 👀 ? |
Amazing! Yes, bumping the upper range to include up to |
It's too late in the day today so I'll try to get a release out as quickly as tomorrow :) |
Sounds good! |
@0xRAG web3.py |
Amazing, thanks @fselmo! |
Confirmed this unblocked us @fselmo! If you're curious, here's a PR in AgentKit bumping web3.py and adding support for the OpenAI voice agent coinbase/agentkit#620 |
Happy to hear it @0xRAG! Thanks for sharing and glad to have unblocked everyone dependent on this. I think this was a very good example of how to break things by |
What was wrong?
OpenAI Agents released voice support, but it requires websockets 15+. In AgentKit we use web3.py extensively in our core package. We would like to support OpenAI's voice-enabled agents which is possible only through upgrading web3.py's dependency on
websockets
.Related to and closes #3641
How was it fixed?
There are some breaking changes in between
websockets
13 and 15, however there are access points for newly deprecated methods and fields. I'm sure the web3.py library would like to take advantage of the improvements towebsockets
(there is a full upgrade guide here), but for the (admittedly selfish) scope of combining web3.py & AgentKit & OpenAI Agents, this PR should suffice, while being directionally correct.I tested the changes by installing the latest
websockets
and running the full test suite viamake test
. The test results are exactly the same as on main.References
Todo:
Cute Animal Picture