Export a removeFromCache(filepath) function #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
pushed a commit
to facebook/flow
that referenced
this pull request
Sep 30, 2016
Summary: I have little faith that evanw/node-source-map-support#149 will get merged any time soon. That means we have to make do with out-of-date source maps when tests change. Luckily, record is the only command that really relies on the source maps. So we can just spawn a new process and its source maps will be up to date! Hooray! Reviewed By: samwgoldman Differential Revision: D3949020 fbshipit-source-id: 10f34f58c76f14fb948c0a3d9265b4f9150ce393
|
If #118 lands, then this will happen automatically, I believe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
require('source-map-support').removeFromCache('path/to/foo.js')will removepath/to/foo.jsfrom the source map cache.Motivation
I use am using
babel-register. At some point, my program notices that a file changes. So it callsExpected behavior
Stack traces show lines/columns from the updated file
Actual behavior
Stack traces still use the old source maps, so the locations are out of date
How this helps
After this lands, I can update
babel-registerto callremoveFromCache(filename)whenever it transforms a file.