Fix #961: Change Forth stack return type to slice #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #961: returning an owned value for a getter that is used for tests only is a bit silly, so this changes the return type of the `Forth::stack` method from `Vec<Value>` to `&[Value]`. It does not require changing the tests. Signed-off-by: Paul Mabileau <[email protected]>
coriolinus
approved these changes
Nov 20, 2020
|
Me too 😄! |
|
Actually, I shouldn't have merged quite that quickly. Would you please update |
|
Okay, I'll get on it then! |
|
Wait, actually @coriolinus, the stack used in the example surprisingly is a |
|
Yes, please.
…On Fri, Nov 20, 2020 at 5:17 PM Paul Mabileau ***@***.***> wrote:
Wait, actually @coriolinus <https://github.com/coriolinus>, the stack
used in the example surprisingly is a LinkedList instead of a Vec so
borrowing a slice is impossible... Should we try to refactor the example in
order to use a vector instead?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1032 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB3V4TV2XZSWVL5SN7DESVDSQ2JA3ANCNFSM4T44TT4A>
.
|
|
Okay, I just didn't know if it was something we could consider |
coriolinus
pushed a commit
that referenced
this pull request
Nov 20, 2020
As discussed in #1032, the PR was merged too quickly, so this is to complete the contribution by updating the exercise's example in order to be compatible with the modified unit tests. Signed-off-by: Paul Mabileau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #961: as discussed, this adjusts the return type to
&[Value]in order to reduce the amount of cloning required and since it is used for tests only, it does not truly break the type's API.