Router As Separate Module

[wesleytodd]

I searched through the issues but couldn't find any previous discussion of this. Has there been any talk, or is there currently, of moving the Router out into a stand-alone module?

[dougwilson]

There has and it will :)! I'll keep this open until it does, and I can link the 5.0 TODO to this ticket.

[wesleytodd]

Awesome! Thanks for the quick reply. If you have any references to where this discussion is happening I would love to browse through it....and maybe add in my 2c :)

[dougwilson]

Discussion was really a "hey, let's take the exact router that's in express 4 and put it in a new module", really :) If there is anything specific you'd like to discuss, please feel free to use this issue as the forum, as I don't think there was one anywhere permanent before.

[ajacksified]

That would be awesome. I ended up pulling it out into a separate module for my own use: https://github.com/ajacksified/express-router

[Fishrock123]

@ajacksified Note: the official one will be here: https://github.com/pillarjs/router

The first commit is still wip though, and I think @dougwilson is still going to push over it a couple times.

[Fishrock123]

Also discussion in #2431

[dougwilson]

and I think @dougwilson is still going to push over it a couple times

indeed :) the biggest thing is the router at pillarjs/router will be usable without express methods on the prototype (i.e. http.createServer(router) and the like) which makes it much more usable than a straight express 4 router extraction.

[ajacksified]

The current express 4 router, extracted as-is, doesn't create a server or appear to rely on express (I may be missing something somewhere); but, at any rate, that's a great goal.

My own motivations are weird: I just want something that maps express-style routes to a function, that I can use client- and server- side; existing routers like director and router.js make a lot of assumptions and I need something lower-level and more lightweight, a thin layer on top of path-to-regexp.

[Fishrock123]

@ajacksified sounds like a custom router is right for you then. :)

I may suggest basing it off of the extracted router once it;s ready though - it will probably be more stable.

[ajacksified]

@Fishrock123 Yup, I'll keep an eye on this - thanks!

[wesleytodd]

@ajacksified I am in a very similar situation, so you are not weird in that. I am working on an isomorphic app where it would be really nice to define our routes/middleware once. @Fishrock123 are you saying that a use case like this would be better suited to a different solution?

[Fishrock123]

Speaking of thin layers on top of path-to-regexp, does path-match fill your needs? (tbh, I will actually need a front-end router for my own app within a few days.)

@wesleytodd I am saying this is the perfect case for a custom router. For maximum interoperability, it may be worthwhile basing your router's top-level off of the one extracted from express, however.

[mahnunchik]

+1

[Fishrock123]

fwiw, for front-end I went with @yoshuawuyts's wayfarer (built on jonathan's trie-router)

The current impl doesn't work as a full pillarjs router though, afaik.

[dougwilson]

For those coming by, I just published the first version of the official one from https://github.com/pillarjs/router as [email protected] on npm.

[wesleytodd]

@dougwilson Thanks!

[hacksparrow]

👍

[AndrewJHart]

👍

[Fishrock123]

@dougwilson router has been extracted, can this be closed & checked off the list?

[dougwilson]

Once the 5.0 branch is actually using it :)

[dougwilson]

Ok, this has been integrated in the 5.0 branch and published as part of the 5.0.0-alpha.2 release!

[hacksparrow]

👍🏻 excellent!

[wesleytodd]

👏 👏 👏 👏