-
-
Notifications
You must be signed in to change notification settings - Fork 18.3k
Update docs #3836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs #3836
Conversation
Hey @jamesgeorge007. I feel like we discussed badges at some point and decided to use the badge board for these? Maybe it was in this one? #3710 |
Yea, I'm iffy on adding a badge, of which a lot of those points are in what @wesleytodd linked to. But also I leaned that there are quite often new users who don't even know what "PR" stands for and I had to explain. I think if it's to be for users who don't think they can make a pull request in github already, they are likely in this group, so the PR badge is just going to go over their head. Perhaps instead of a badge, there should just be a contributing section added to the readme? It could just have a basic blurb about making one and have the link to contributing like this badge does. |
@wesleytodd @dougwilson Well if that's the case, shall I proceed with adding contributing guidelines section to the
|
@jamesgeorge007 that Twitter account does not belong to the express project. |
removes PR welcoming badge
@dougwilson Removed the badge and added contributing guidelines section as you suggested. |
Two things:
|
@wesleytodd @dougwilson I had to close this as part of switching to another branch. |
It is fine to open a new PR but also if you are interested, you can use |
@wesleytodd Check out this stack-overflow discussion |
I think it is a good idea to have a badge welcoming pull requests pointing to the
contributing.md
file 🤔