set allchunks: true for ExtractTextPlugin #3908
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viankakrisna
force-pushed
the
css-allchunks
branch
5 times, most recently
from
2e53be8 to
810cd96
Compare
viankakrisna
force-pushed
the
css-allchunks
branch
from
810cd96 to
377a576
Compare
viankakrisna
commented
Feb 6, 2018
| @@ -17,8 +17,10 @@ describe('Integration', () => { | |||
| doc.getElementsByTagName('style')[0].textContent.replace(/\s/g, '') | |||
| ).to.match(/html\{/); | |||
| expect( | |||
| doc.getElementsByTagName('style')[1].textContent.replace(/\s/g, '') | |||
| doc.getElementsByTagName('style')[0].textContent.replace(/\s/g, '') | |||
There was a problem hiding this comment.
i just realize that this only test the style-loader behaviour in test and dev mode, need to revert this and find out how to test the behaviour for npm run build output
|
Thanks for the PR. With the new Webpack 4 integration CRA is no longer using ExtractTextPlugin. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3086 #2415
prior discussion #408
more details of this behavior webpack/webpack#673